From: Bjorn Helgaas <helgaas@kernel.org>
To: Niklas Cassel <niklas.cassel@axis.com>
Cc: bhelgaas@google.com, jespern@axis.com, linux-arm-kernel@axis.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Niklas Cassel <niklass@axis.com>
Subject: Re: [PATCH] PCI: artpec6: drop __init from artpec6_add_pcie_port
Date: Wed, 14 Sep 2016 16:23:03 -0500 [thread overview]
Message-ID: <20160914212303.GC16581@localhost> (raw)
In-Reply-To: <1473407130-21934-1-git-send-email-niklass@axis.com>
On Fri, Sep 09, 2016 at 09:45:30AM +0200, Niklas Cassel wrote:
> From: Niklas Cassel <niklas.cassel@axis.com>
>
> artpec6_add_pcie_port is called from artpec6_pcie_probe.
> artpec6_pcie_probe does not have the __init section marker.
> It is wrong to have the marker on artpec6_add_pcie_port
> when the marker is not on artpec6_pcie_probe.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>
Applied to pci/host-artpec for v4.9, thanks!
> ---
> drivers/pci/host/pcie-artpec6.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-artpec6.c b/drivers/pci/host/pcie-artpec6.c
> index 16ba70b7..39bf1a6 100644
> --- a/drivers/pci/host/pcie-artpec6.c
> +++ b/drivers/pci/host/pcie-artpec6.c
> @@ -191,8 +191,8 @@ static irqreturn_t artpec6_pcie_msi_handler(int irq, void *arg)
> return dw_handle_msi_irq(pp);
> }
>
> -static int __init artpec6_add_pcie_port(struct pcie_port *pp,
> - struct platform_device *pdev)
> +static int artpec6_add_pcie_port(struct pcie_port *pp,
> + struct platform_device *pdev)
> {
> int ret;
>
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-09-14 21:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 7:45 [PATCH] PCI: artpec6: drop __init from artpec6_add_pcie_port Niklas Cassel
2016-09-14 21:23 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914212303.GC16581@localhost \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=jespern@axis.com \
--cc=linux-arm-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=niklas.cassel@axis.com \
--cc=niklass@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).