From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764211AbcINXyK (ORCPT ); Wed, 14 Sep 2016 19:54:10 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:53114 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762269AbcINXyJ (ORCPT ); Wed, 14 Sep 2016 19:54:09 -0400 Date: Wed, 14 Sep 2016 16:54:05 -0700 From: Josh Triplett To: Christian Borntraeger Cc: Joe Perches , Andrew Morton , Andy Whitcroft , Greg KH , Jonathan Corbet , "Theodore Ts'o" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] checkpatch: Minimize checkpatch induced patches... Message-ID: <20160914235405.GB12672@cloud> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 14, 2016 at 07:56:55PM +0200, Christian Borntraeger wrote: > On 09/14/2016 07:51 PM, Joe Perches wrote: > > checkpatch can be a useful tool for patches. > > > > It can be a much more controversial tool when used on files with the > > -f option for style and whitespace changes for code that is relatively > > stable, obsolete, or for maintained by specific individuals. > > > > o By default, allow checkpatch to be used with the -f|--file option > > for files in drivers/staging/ > > o Add an undocumented --force command line option to be used together > > with the -f|--file option to scan any file > > > > Signed-off-by: Joe Perches > > cc: Greg KH > > cc: Jonathan Corbet > > cc: Josh Triplett > > cc: Christian Borntraeger > > cc: Theodore Ts'o > > This will certainly help to reduce the noise. On the other hand I remember Linus > saying something along the line that he does not like the -f parameter (and he > prefers to set this automatically). So while I like the approach I am not happy > enough to ack right now - still looking for a better alternative :-/ This seems entirely compatible with autodetection. If checkpatch detects that it runs on a file rather than a patch, it can assume -f. It can then apply this same logic to reject that if 1) in a kernel tree and 2) running on a non-staging file and 3) not passed --force.