From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934108AbcIOINu (ORCPT ); Thu, 15 Sep 2016 04:13:50 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:36470 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933584AbcIOINr (ORCPT ); Thu, 15 Sep 2016 04:13:47 -0400 Date: Thu, 15 Sep 2016 10:13:41 +0200 From: Richard Cochran To: Grygorii Strashko Cc: "David S. Miller" , netdev@vger.kernel.org, Mugunthan V N , Sekhar Nori , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, WingMan Kwok Subject: Re: [PATCH 3/9] net: ethernet: ti: cpts: rework initialization/deinitialization Message-ID: <20160915081341.GA25737@localhost.localdomain> References: <20160914130231.3035-1-grygorii.strashko@ti.com> <20160914130231.3035-4-grygorii.strashko@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160914130231.3035-4-grygorii.strashko@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 14, 2016 at 04:02:25PM +0300, Grygorii Strashko wrote: > The current implementation CPTS initialization and deinitialization > (represented by cpts_register/unregister()) is pretty entangled and > has some issues, like: > - ptp clock registered before spinlock, which is protecting it, and > before timecounter and cyclecounter initialization; > - CPTS ref_clk requested using devm API while cpts_register() is > called from .ndo_open(), as result additional checks required; > - CPTS ref_clk is prepared, but never unprepared; > - CPTS is not disabled even when unregistered.. This list of four items is a clear sign that this one patch should be broken into a series of four. Thanks, Richard