From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765191AbcIOKIR (ORCPT ); Thu, 15 Sep 2016 06:08:17 -0400 Received: from mail.kernel.org ([198.145.29.136]:44638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753312AbcIOKIP (ORCPT ); Thu, 15 Sep 2016 06:08:15 -0400 Date: Thu, 15 Sep 2016 13:07:57 +0300 From: Leon Romanovsky To: Salil Mehta Cc: dledford@redhat.com, xavier.huwei@huawei.com, oulijun@huawei.com, yisen.zhuang@huawei.com, xuwei5@hisilicon.com, mehta.salil.lnk@gmail.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com Subject: Re: [PATCH for-next 03/20] IB/hns: Add the check for pointer ctrl Message-ID: <20160915100757.GW26069@leon.nu> References: <1473417051-99560-1-git-send-email-salil.mehta@huawei.com> <1473417051-99560-4-git-send-email-salil.mehta@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hSsVBZHIO2Q9XETc" Content-Disposition: inline In-Reply-To: <1473417051-99560-4-git-send-email-salil.mehta@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --hSsVBZHIO2Q9XETc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 09, 2016 at 06:30:34PM +0800, Salil Mehta wrote: > From: Lijun Ou > > The pointer ctrl may be null, so we add check for it. > > Signed-off-by: Lijun Ou > Reviewed-by: Wei Hu > Signed-off-by: Salil Mehta > --- > drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c > index 5f76fc1..ea47ec4 100644 > --- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c > +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c > @@ -336,6 +336,12 @@ int hns_roce_v1_post_recv(struct ib_qp *ibqp, struct ib_recv_wr *wr, > } > > ctrl = get_recv_wqe(hr_qp, ind); > + if (unlikely(!ctrl)) { Yes, as you wrote, this check and patch are redundant too. > + dev_err(dev, "Get recv wqe failed!\n"); > + ret = -EINVAL; > + *bad_wr = wr; > + goto out; > + } > > roce_set_field(ctrl->rwqe_byte_12, > RQ_WQE_CTRL_RWQE_BYTE_12_RWQE_SGE_NUM_M, > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --hSsVBZHIO2Q9XETc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJX2nL9AAoJEORje4g2clinZmMP/im4M9pdOpBR/vDGAf3ZqRq4 1pnQHNkUXP8+NO8DHAiWHRazz0+yGB80kPheumaDQdObK9/9mVzxZABtluT1TXqJ ZF4GSCzUCqEf9OpPFxKSvAj4o9DoTNsAkJnUpdrW7g3TyJvvmG+zW1L/9CFVIxUt UCpEZQoPS8shmB/BINlBuBYgMk+bZAotHeo1DgFFJjYAwuHco3eIwPuhyyjyaTK4 wR0SILcczDlg19PbqfbFK3eAX/if2HFmoVPRb1qWHi9kKXpNmdRLXdA8I4jgB5Da Xtz+DGPVrjxxlv5i1g2/wv/a0V8Z6ePcLbESFdwNJRHe3AWzt5bsHh5F5V9ewtm3 lIOAw2CGMe6Wt1ATL9aLSKnLlJtLzTgT4v0M8CtCmj2viDmGbRxGGXLVNSPzULgg BA9GN4E3YKdjDfbhpERrPIq34zHqj3HYxlXVE0om/dt9z7K+Lp2nhhH6do59uvBc 2Txls9++u2OiWg3jSpPxdwVZ1xzkR2duNcEn2TNF3xWzgBkI4ZMj73wSH5Sfe1rV kGeNsf5E4IWnhi9R+CPtV2J3TgzT6djBH9T0JwJOLlU9ZlVavbOEKvU+uMWBNttA vlAwHFrva16z+I7TLLEmIvbTqpgDOPXv9aMbfWZ9zvzz48GrJysSS+iUFvjVFEIm tTUthHwCYEdMdidZaruD =pkJw -----END PGP SIGNATURE----- --hSsVBZHIO2Q9XETc--