From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933917AbcIOMb6 (ORCPT ); Thu, 15 Sep 2016 08:31:58 -0400 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:49003 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755773AbcIOMb5 (ORCPT ); Thu, 15 Sep 2016 08:31:57 -0400 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.wolfsonmicro.com Date: Thu, 15 Sep 2016 13:31:55 +0100 From: Charles Keepax To: Viresh Kumar CC: Lee Jones , , "Mark Brown" , Krzysztof =?utf-8?Q?Koz=C5=82owski?= , , Subject: Re: [PATCH 1/2] mfd: wm8994-core: disable regulators before removing them Message-ID: <20160915123155.GP21682@localhost.localdomain> References: <9f4aa8441344137272549e65d81c7fe65e37a8a8.1473938123.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <9f4aa8441344137272549e65d81c7fe65e37a8a8.1473938123.git.viresh.kumar@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609020000 definitions=main-1609150169 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 15, 2016 at 04:47:00PM +0530, Viresh Kumar wrote: > The order in which resources were freed in wm8994_device_exit() isn't > correct. The regulators are removed before they are disabled. > > Fix it by reordering code a bit, which makes it exact opposite of > wm8994_device_init() as well. > > Signed-off-by: Viresh Kumar > --- Acked-by: Charles Keepax Thanks, Charles