From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758607AbcIONgL (ORCPT ); Thu, 15 Sep 2016 09:36:11 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:60629 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755495AbcIONgC (ORCPT ); Thu, 15 Sep 2016 09:36:02 -0400 Date: Thu, 15 Sep 2016 15:35:58 +0200 From: Pavel Machek To: Jacek Anaszewski Cc: David Lechner , Richard Purdie , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, Marcel Holtmann Subject: Re: [PATCH v3] leds: Introduce userspace leds driver Message-ID: <20160915133558.GA29883@amd> References: <1473439776-15655-1-git-send-email-david@lechnology.com> <80597ded-f4b4-2990-3eae-e72276296d1a@samsung.com> <20160915130831.GJ13132@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160915130831.GJ13132@amd> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > >+ if (copy_from_user(&udev->user_dev, buffer, > > >+ sizeof(struct uleds_user_dev))) { > > >+ ret = -EFAULT; > > >+ goto out; > > >+ } > > >+ > > >+ if (!udev->user_dev.name[0]) { > > >+ ret = -EINVAL; > > >+ goto out; > > >+ } > > >+ > > >+ ret = led_classdev_register(NULL, &udev->led_cdev); > > >+ if (ret < 0) > > >+ goto out; > > No sanity checking on the name -> probably a security hole. Do not > push this upstream before this is fixed. And actually... is it possible to have more then one userspace LED with this interface? I do have RGB LED connect on /dev/ttyUSB0, and I guess userspace driver would be appropriate, but it needs 3 channels... Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html