From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752758AbcIOOvj (ORCPT ); Thu, 15 Sep 2016 10:51:39 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58005 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752582AbcIOOv0 (ORCPT ); Thu, 15 Sep 2016 10:51:26 -0400 Date: Thu, 15 Sep 2016 16:51:31 +0200 From: Greg KH To: Sergio Paracuellos Cc: bhumirks@gmail.com, jrickertkc@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rts5208: Comparisons should place the constant on the right side of the test Message-ID: <20160915145131.GA26016@kroah.com> References: <1473949794-9708-1-git-send-email-sergio.paracuellos@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1473949794-9708-1-git-send-email-sergio.paracuellos@gmail.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 15, 2016 at 04:29:54PM +0200, Sergio Paracuellos wrote: > Signed-off-by: Sergio Paracuellos > --- > drivers/staging/rts5208/rtsx_card.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rts5208/rtsx_card.c b/drivers/staging/rts5208/rtsx_card.c > index 9a5cd63..551e3064 100644 > --- a/drivers/staging/rts5208/rtsx_card.c > +++ b/drivers/staging/rts5208/rtsx_card.c > @@ -645,7 +645,7 @@ int switch_ssc_clock(struct rtsx_chip *chip, int clk) > dev_dbg(rtsx_dev(chip), "Switch SSC clock to %dMHz (cur_clk = %d)\n", > clk, chip->cur_clk); > > - if ((clk <= 2) || (N > max_N)) { > + if ((clk <= 2) || (max_N < N)) { Where is the constant? The original code looks fine to me... Also, I can't take patches where there is no changelog text, sorry. greg k-h