From: Josh Triplett <josh@joshtriplett.org>
To: Richard Cochran <richardcochran@gmail.com>
Cc: John Stultz <john.stultz@linaro.org>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3) posix-timers: make it configurable
Date: Thu, 15 Sep 2016 14:15:55 -0700 [thread overview]
Message-ID: <20160915211555.GA16992@cloud> (raw)
In-Reply-To: <20160915210724.GB4245@localhost.localdomain>
On Thu, Sep 15, 2016 at 11:07:24PM +0200, Richard Cochran wrote:
> On Thu, Sep 15, 2016 at 12:58:22PM -0700, John Stultz wrote:
> > This doesn't look too bad.
>
> I disagree. It looks ugly. If tinification means sprinkling more and
> more of these conditionals all over the place, then it is going to be
> a tough sell.
Looking at this particular patch, it does seem a bit much for the
ability to have PTP without timers. That doesn't seem like a very
likely combination. Handling that in Kconfig seems fine, unless there's
a concrete use case for that combination.
- Josh Triplett
next prev parent reply other threads:[~2016-09-15 21:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 3:47 [PATCH v3) posix-timers: make it configurable Nicolas Pitre
2016-09-15 17:48 ` John Stultz
2016-09-15 17:56 ` Nicolas Pitre
2016-09-15 18:13 ` John Stultz
2016-09-15 18:28 ` Nicolas Pitre
2016-09-15 18:35 ` John Stultz
2016-09-15 18:37 ` Nicolas Pitre
2016-09-15 18:46 ` John Stultz
2016-09-15 19:31 ` Nicolas Pitre
2016-09-15 19:58 ` John Stultz
2016-09-15 21:07 ` Richard Cochran
2016-09-15 21:15 ` Josh Triplett [this message]
2016-09-15 21:35 ` Nicolas Pitre
2016-09-15 21:56 ` Josh Triplett
2016-09-16 7:24 ` Richard Cochran
2016-09-17 2:57 ` Nicolas Pitre
2016-09-18 14:35 ` Richard Cochran
2016-09-18 16:54 ` Nicolas Pitre
2016-09-18 18:20 ` Richard Cochran
2016-09-18 18:49 ` Nicolas Pitre
2016-09-18 20:22 ` Richard Cochran
2016-09-18 20:30 ` Nicolas Pitre
2016-09-18 21:11 ` Richard Cochran
2016-09-15 21:23 ` Richard Cochran
2016-09-16 14:31 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160915211555.GA16992@cloud \
--to=josh@joshtriplett.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).