From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753936AbcIOVQH (ORCPT ); Thu, 15 Sep 2016 17:16:07 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:56071 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752265AbcIOVP7 (ORCPT ); Thu, 15 Sep 2016 17:15:59 -0400 Date: Thu, 15 Sep 2016 14:15:55 -0700 From: Josh Triplett To: Richard Cochran Cc: John Stultz , Nicolas Pitre , Thomas Gleixner , lkml Subject: Re: [PATCH v3) posix-timers: make it configurable Message-ID: <20160915211555.GA16992@cloud> References: <20160915210724.GB4245@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160915210724.GB4245@localhost.localdomain> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 15, 2016 at 11:07:24PM +0200, Richard Cochran wrote: > On Thu, Sep 15, 2016 at 12:58:22PM -0700, John Stultz wrote: > > This doesn't look too bad. > > I disagree. It looks ugly. If tinification means sprinkling more and > more of these conditionals all over the place, then it is going to be > a tough sell. Looking at this particular patch, it does seem a bit much for the ability to have PTP without timers. That doesn't seem like a very likely combination. Handling that in Kconfig seems fine, unless there's a concrete use case for that combination. - Josh Triplett