From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755519AbcIOVXk (ORCPT <rfc822;w@1wt.eu>);
        Thu, 15 Sep 2016 17:23:40 -0400
Received: from mail-wm0-f42.google.com ([74.125.82.42]:38379 "EHLO
        mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753112AbcIOVXc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 15 Sep 2016 17:23:32 -0400
Date: Thu, 15 Sep 2016 23:23:26 +0200
From: Richard Cochran <richardcochran@gmail.com>
To: John Stultz <john.stultz@linaro.org>
Cc: Nicolas Pitre <nicolas.pitre@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Josh Triplett <josh@joshtriplett.org>,
        lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3) posix-timers: make it configurable
Message-ID: <20160915212326.GC4245@localhost.localdomain>
References: <alpine.LFD.2.20.1609142340540.14769@knanqh.ubzr>
 <CALAqxLVfu3+-9Ucu4zvaeWXW3kpBeVZFhy831v31gmRFMBOCpw@mail.gmail.com>
 <alpine.LFD.2.20.1609151426420.14769@knanqh.ubzr>
 <CALAqxLVrOMC9Ux0as37CMwoKaWZdaABxqyh2XymbE4yoy8htBQ@mail.gmail.com>
 <alpine.LFD.2.20.1609151436000.14769@knanqh.ubzr>
 <CALAqxLVAnRoA_+AM1pO_Q-P1Uadaq7MSnmVaVOvjqxr-Tvry6A@mail.gmail.com>
 <alpine.LFD.2.20.1609151523510.14769@knanqh.ubzr>
 <CALAqxLWW1qsq0_C2kiW+GgPk8x-dHS317eRUUhK=CG4MpQgxMQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALAqxLWW1qsq0_C2kiW+GgPk8x-dHS317eRUUhK=CG4MpQgxMQ@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 15, 2016 at 12:58:22PM -0700, John Stultz wrote:
> This doesn't look too bad.

Actually, it is worse than ugly.  It is a disaster.  With this change,
registration will succeed and MAC drivers will happily report the PTP
devices in 'ethtool -T', but there won't be anything behind them.

IMHO, it would be better in this case to stub out the whole
subsystem.  That would save you ptp_clock.o, ptp_chardev.o, and
ptp_sysfs.o.

Thanks,
Richard