From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756307AbcIOV5B (ORCPT <rfc822;w@1wt.eu>);
        Thu, 15 Sep 2016 17:57:01 -0400
Received: from relay3-d.mail.gandi.net ([217.70.183.195]:37232 "EHLO
        relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753951AbcIOV4x (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 15 Sep 2016 17:56:53 -0400
Date: Thu, 15 Sep 2016 14:56:49 -0700
From: Josh Triplett <josh@joshtriplett.org>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: Richard Cochran <richardcochran@gmail.com>,
        John Stultz <john.stultz@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3) posix-timers: make it configurable
Message-ID: <20160915215649.GA17171@cloud>
References: <CALAqxLVfu3+-9Ucu4zvaeWXW3kpBeVZFhy831v31gmRFMBOCpw@mail.gmail.com>
 <alpine.LFD.2.20.1609151426420.14769@knanqh.ubzr>
 <CALAqxLVrOMC9Ux0as37CMwoKaWZdaABxqyh2XymbE4yoy8htBQ@mail.gmail.com>
 <alpine.LFD.2.20.1609151436000.14769@knanqh.ubzr>
 <CALAqxLVAnRoA_+AM1pO_Q-P1Uadaq7MSnmVaVOvjqxr-Tvry6A@mail.gmail.com>
 <alpine.LFD.2.20.1609151523510.14769@knanqh.ubzr>
 <CALAqxLWW1qsq0_C2kiW+GgPk8x-dHS317eRUUhK=CG4MpQgxMQ@mail.gmail.com>
 <20160915210724.GB4245@localhost.localdomain>
 <20160915211555.GA16992@cloud>
 <alpine.LFD.2.20.1609151722080.9883@knanqh.ubzr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.LFD.2.20.1609151722080.9883@knanqh.ubzr>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 15, 2016 at 05:35:28PM -0400, Nicolas Pitre wrote:
> On Thu, 15 Sep 2016, Josh Triplett wrote:
> 
> > On Thu, Sep 15, 2016 at 11:07:24PM +0200, Richard Cochran wrote:
> > > On Thu, Sep 15, 2016 at 12:58:22PM -0700, John Stultz wrote:
> > > > This doesn't look too bad.
> > > 
> > > I disagree.  It looks ugly.  If tinification means sprinkling more and
> > > more of these conditionals all over the place, then it is going to be
> > > a tough sell.
> > 
> > Looking at this particular patch, it does seem a bit much for the
> > ability to have PTP without timers.  That doesn't seem like a very
> > likely combination.  Handling that in Kconfig seems fine, unless there's
> > a concrete use case for that combination.
> 
> I doubt there is.  This is more for randconfig purposes or the like.
> 
> I suspect there is more of a case for having net drivers _without_ ptp 
> support.  This could be implemented with a ptp_clock_register() stub 
> returning NULL when ptp is not configured.  I didn't look at most 
> drivers but at least broadcom/tg3.c seems to be fine with such an 
> approach.
> 
> Alternatively, all those ethernet drivers currently selecting 
> PTP_1588_CLOCK could be banned from the kernel config when POSIX_TIMERS 
> is not selected.
> 
> What do people prefer?

If the stubs prove as simple as you suggest above (a static inline
returning NULL), that sounds ideal.  If this would require a non-trivial
amount of stub code, then preventing those drivers from building without
POSIX_TIMERS seems preferable to that.