From: Matt Fleming <matt@codeblueprint.co.uk>
To: Mike Galbraith <umgwanakikbuti@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
linux-efi@vger.kernel.org, Peter Jones <pjones@redhat.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [tip regression] efi: Allow drivers to reserve boot services forever == toxic
Date: Fri, 16 Sep 2016 10:31:49 +0100 [thread overview]
Message-ID: <20160916093149.GC16797@codeblueprint.co.uk> (raw)
In-Reply-To: <1474005912.3930.10.camel@gmail.com>
On Fri, 16 Sep, at 08:05:12AM, Mike Galbraith wrote:
> Hi Matt,
>
> My workstation started instant rebooting with tip. I bisected it to..
>
> efi/esrt: Use efi_mem_reserve() and avoid a kmalloc()
>
> ..but seems it's really $subject, as box works fine with the below.
>
> ---
> drivers/firmware/efi/efi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/drivers/firmware/efi/efi.c
> +++ b/drivers/firmware/efi/efi.c
> @@ -415,6 +415,7 @@ void __init efi_mem_reserve(phys_addr_t
> {
> if (!memblock_is_region_reserved(addr, size))
> memblock_reserve(addr, size);
> + else
>
> /*
> * Some architectures (x86) reserve all boot services ranges
>
>
> No idea what's going boom down in efi_arch_mem_reserve().
Urgh, that's bad. Which machine is this? Can you paste the dmesg after
booting with the efi=debug kernel parameter, either with your above
patch or with the commit reverted?
next prev parent reply other threads:[~2016-09-16 9:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 6:05 [tip regression] efi: Allow drivers to reserve boot services forever == toxic Mike Galbraith
2016-09-16 9:31 ` Matt Fleming [this message]
2016-09-16 10:00 ` Mike Galbraith
2016-09-16 14:30 ` Matt Fleming
2016-09-16 14:45 ` Mark Rutland
2016-09-16 18:26 ` Mike Galbraith
2016-09-19 8:56 ` Mark Rutland
2016-09-16 16:34 ` Mike Galbraith
2016-09-17 19:58 ` Matt Fleming
2016-09-18 6:09 ` Mike Galbraith
2016-09-19 11:15 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160916093149.GC16797@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=ard.biesheuvel@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pjones@redhat.com \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).