From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756272AbcIPJcC (ORCPT ); Fri, 16 Sep 2016 05:32:02 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:37360 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751056AbcIPJbw (ORCPT ); Fri, 16 Sep 2016 05:31:52 -0400 Date: Fri, 16 Sep 2016 10:31:49 +0100 From: Matt Fleming To: Mike Galbraith Cc: Ingo Molnar , LKML , linux-efi@vger.kernel.org, Peter Jones , Ard Biesheuvel Subject: Re: [tip regression] efi: Allow drivers to reserve boot services forever == toxic Message-ID: <20160916093149.GC16797@codeblueprint.co.uk> References: <1474005912.3930.10.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474005912.3930.10.camel@gmail.com> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Sep, at 08:05:12AM, Mike Galbraith wrote: > Hi Matt, > > My workstation started instant rebooting with tip. I bisected it to.. > > efi/esrt: Use efi_mem_reserve() and avoid a kmalloc() > > ..but seems it's really $subject, as box works fine with the below. > > --- > drivers/firmware/efi/efi.c | 1 + > 1 file changed, 1 insertion(+) > > --- a/drivers/firmware/efi/efi.c > +++ b/drivers/firmware/efi/efi.c > @@ -415,6 +415,7 @@ void __init efi_mem_reserve(phys_addr_t > { > if (!memblock_is_region_reserved(addr, size)) > memblock_reserve(addr, size); > + else > > /* > * Some architectures (x86) reserve all boot services ranges > > > No idea what's going boom down in efi_arch_mem_reserve(). Urgh, that's bad. Which machine is this? Can you paste the dmesg after booting with the efi=debug kernel parameter, either with your above patch or with the commit reverted?