From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933926AbcIPLW7 (ORCPT ); Fri, 16 Sep 2016 07:22:59 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:41791 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755500AbcIPLWw (ORCPT ); Fri, 16 Sep 2016 07:22:52 -0400 Date: Fri, 16 Sep 2016 14:22:34 +0300 From: Dan Carpenter To: Sergio Paracuellos Cc: Greg KH , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, bhumirks@gmail.com, jrickertkc@gmail.com Subject: Re: [PATCH] staging: rts5208: Comparisons should place the constant on the right side of the test Message-ID: <20160916112234.GB13620@mwanda> References: <1473949794-9708-1-git-send-email-sergio.paracuellos@gmail.com> <20160915145131.GA26016@kroah.com> <57DAD8E0.1050306@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57DAD8E0.1050306@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 15, 2016 at 07:22:40PM +0200, Sergio Paracuellos wrote: > That's true. It seems that checkpatch script is getting a false > positive. Just trying to do checkpatch happy. Also the old code was better than new code so leave it alone. regards, dan carpenter