From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934347AbcIPLXt (ORCPT ); Fri, 16 Sep 2016 07:23:49 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:38023 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933190AbcIPLXl (ORCPT ); Fri, 16 Sep 2016 07:23:41 -0400 Date: Fri, 16 Sep 2016 04:23:41 -0700 From: Christoph Hellwig To: Miklos Szeredi Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Al Viro Subject: Re: [PATCH 07/11] pipe: remove generic_pipe_buf_confirm() Message-ID: <20160916112341.GA3050@infradead.org> References: <1473842236-28655-1-git-send-email-mszeredi@redhat.com> <1473842236-28655-8-git-send-email-mszeredi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1473842236-28655-8-git-send-email-mszeredi@redhat.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > static inline int pipe_buf_confirm(struct pipe_inode_info *pipe, > struct pipe_buffer *buf) > { > - return buf->ops->confirm(pipe, buf); > + return 0; > } Why do you keep pipe_buf_confirm around?