From: Rob Herring <robh@kernel.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Mark Brown <broonie@kernel.org>,
lgirdwood@gmail.com, Douglas Anderson <dianders@chromium.org>,
briannorris@chromium.org, javier@dowhile0.org,
mark.rutland@arm.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 3/4] regulator: Add support for a fixed delay after voltage increases
Date: Fri, 16 Sep 2016 07:28:40 -0500 [thread overview]
Message-ID: <20160916122840.GA3388@rob-hp-laptop> (raw)
In-Reply-To: <20160906190504.GA79728@google.com>
On Tue, Sep 06, 2016 at 12:05:04PM -0700, Matthias Kaehlcke wrote:
> The target voltage isn't necessarily reached inmediately after
> requesting a regulator to change the voltage. In some cases the
> ramp_delay can be used to calculate the stabilisation time, in others
> there is no direct relationship between the delta in the voltage and
> the stabilisation time. This change introduces the device tree property
> "regulator-settle-time-up-us" which allows to specify a fixed delay
> after a voltage increase.
>
> We don't add an option of a fixed delay on the way down for now because
> the way down is probably modelled best with a ramp rate, not a fixed
> delay.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
>
> ---
> Changes in v4:
> - Moved from PWM regulator to regulator core
> - Added 'regulator' prefix to device tree property
>
> .../devicetree/bindings/regulator/regulator.txt | 2 ++
> drivers/regulator/core.c | 24 +++++++++++++---------
> drivers/regulator/of_regulator.c | 4 ++++
> include/linux/regulator/machine.h | 2 ++
> 4 files changed, 22 insertions(+), 10 deletions(-)
Acked-by: Rob Herring <robh@kernel.org>
prev parent reply other threads:[~2016-09-16 12:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 19:05 [PATCH v4 3/4] regulator: Add support for a fixed delay after voltage increases Matthias Kaehlcke
2016-09-12 18:36 ` Mark Brown
2016-09-15 12:51 ` Doug Anderson
2016-09-16 12:28 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160916122840.GA3388@rob-hp-laptop \
--to=robh@kernel.org \
--cc=briannorris@chromium.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=javier@dowhile0.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox