Re: [PATCH v3] scripts: add script for translating stack dump function

Rabin Vincent
2016-09-19T20:01:09Z

On Mon, Sep 19, 2016 at 12:15:42PM -0700, Linus Torvalds wrote:
> Hmm. Would you mind if I change the
>
> addr2line -fpie $objfile $hexaddr | sed "s;$dir_prefix;;"
>
> into
>
> addr2line -fpie $objfile $hexaddr |
> sed "s; at $dir_prefix\(\./\)*; at ;"
>
> instead? There's two changes there: matching the " at " part (to just
> make the match stricter) but also matching any following "./" thing
> (which shows up for our include tree files, at least for me).

Note that addr2line has localized strings, so the regex with the " at "
won't match for everyone unless you invoke addr2line with LANG=C.

$ ../linux/scripts/faddr2line vmlinux free_reserved_area+61
free_reserved_area+61/0xe4:
__write_once_size på /home/rabinv/dev/linux/include/linux/compiler.h:248
(inline:ad av)set_page_count på /home/rabinv/dev/linux/include/linux/page_ref.h:76
(inline:ad av)init_page_count på /home/rabinv/dev/linux/include/linux/page_ref.h:87
(inline:ad av)__free_reserved_page på /home/rabinv/dev/linux/include/linux/mm.h:1818
(inline:ad av)free_reserved_page på /home/rabinv/dev/linux/include/linux/mm.h:1824
(inline:ad av)free_reserved_area på /home/rabinv/dev/linux/mm/page_alloc.c:6476

$ LANG=C ../linux/scripts/faddr2line vmlinux free_reserved_area+61
free_reserved_area+61/0xe4:
__write_once_size at include/linux/compiler.h:248
(inlined by) set_page_count at include/linux/page_ref.h:76
(inlined by) init_page_count at include/linux/page_ref.h:87
(inlined by) __free_reserved_page at include/linux/mm.h:1818
(inlined by) free_reserved_page at include/linux/mm.h:1824
(inlined by) free_reserved_area at mm/page_alloc.c:6476