Re: [PATCH v3] scripts: add script for translating stack dump function

Josh Poimboeuf
2016-09-19T21:07:35Z

On Mon, Sep 19, 2016 at 02:02:18PM -0700, Linus Torvalds wrote:
> On Mon, Sep 19, 2016 at 1:56 PM, Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> > On Mon, Sep 19, 2016 at 01:24:03PM -0700, Linus Torvalds wrote:
> >>
> >> because I certainly hope there is always a space there.
> >
> > No luck. The Japanese translation uses an empty string:
>
> Heh.
>
> Ok, we don't want to *just* have the "./" pattern ever be replaced,
> because for all I know there could be a directory name ending with "."
> in there somewhere.
>
> But I guess we could do it this way instead:
>
> --- a/scripts/faddr2line
> +++ b/scripts/faddr2line
> @@ -79,7 +79,7 @@ find_dir_prefix() {
> return
> fi
>
> - DIR_PREFIX=$prefix
> + DIR_PREFIX="$prefix\(\./\)*"
> return 0
> }
>
> and thus just make it part of the auto-generated pattern string instead.

Actually, false alarm. The empty translation string seems to mean "use
the original string":

$ export LANG=ja_JP.utf8
$ ./scripts/faddr2line ~/k/vmlinux type_show+0x10/45
type_show+0x10/0x2d:
type_show at drivers/video/backlight/backlight.c:213

So your previous patch which checks for a space looks good after all :-)

--
Josh