From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935991AbcIPPeP (ORCPT ); Fri, 16 Sep 2016 11:34:15 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:32829 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757803AbcIPPeF (ORCPT ); Fri, 16 Sep 2016 11:34:05 -0400 Date: Fri, 16 Sep 2016 17:34:02 +0200 From: Thierry Reding To: Vinay Simha BN Cc: Archit Taneja , Rob Clark , Sumit Semwal , John Stultz , Emil Velikov , David Airlie , open list , "open list:DRM PANEL DRIVERS" Subject: Re: [PATCH v10 3/3] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel Message-ID: <20160916153402.GF12753@ulmo.ba.sec> References: <1472179029-9803-1-git-send-email-simhavcs@gmail.com> <1472179029-9803-3-git-send-email-simhavcs@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hK8Uo4Yp55NZU70L" Content-Disposition: inline In-Reply-To: <1472179029-9803-3-git-send-email-simhavcs@gmail.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --hK8Uo4Yp55NZU70L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 26, 2016 at 08:07:07AM +0530, Vinay Simha BN wrote: > Add support for the JDI LT070ME05000 WUXGA DSI panel used in > Nexus 7 2013 devices. >=20 > Programming sequence for the panel is was originally found in the > android-msm-flo-3.4-lollipop-release branch from: > https://android.googlesource.com/kernel/msm.git >=20 > And video mode setting is from dsi-panel-jdi-dualmipi1-video.dtsi > file in: > git://codeaurora.org/kernel/msm-3.10.git LNX.LA.3.6_rb1.27 >=20 > Cc: Archit Taneja > Cc: Rob Clark > Cc: Sumit Semwal > Cc: John Stultz > Cc: Emil Velikov > Cc: Thierry Reding > Cc: David Airlie > Signed-off-by: Sumit Semwal > Signed-off-by: John Stultz > Signed-off-by: Vinay Simha BN > Tested-by: John Stultz > Reviewed-by: Emil Velikov >=20 > --- > v1: > * sumit ported to drm/panel framework, john cherry-picked to mainline, > folded down other fixes from Vinay and Archit, vinay removed interface > setting cmd mode, video mode panel selected >=20 > v2: > * incorporated code reviews from theiry, archit > code style, alphabetical soring in Makefile, Kconfig, regulator_bulk, > arrays of u8, generic helper function, documentation bindings, >=20 > v3: > * dcs backlight support added > * tested this panel driver in nexus7 2013 device >=20 > v4: > * backlight interface added in the panel driver > * incorporated width_mm and height_mm suggested by rob herring >=20 > v5: > * theirry review comments incorporated > panel model naming consistent, alphabetical soring in Kconfig > Makefile, MAX_BRIGHTNESS dropped, regulator_names, parameterize > panel width and height, descprition for control display, cabc > and interface setting, temporary variable removed, consistent > error reporting and commit message > * removed tear on/off, scanline, since these are required only > for command mode panels >=20 > v6: > * emil review comments incorporated > PANEL_NUM_REGULATORS dropped, return ret added at necessary > places, if checks dropped for backlight and gpios >=20 > v7: > * emil review comments incorporated > added ARRAY_SIZE in struct, regulator_bulk_disable in poweroff, > gpios checks dropped. > some returns cannot be dropped, since drm panel framework return > type required. >=20 > v8: > * emil review commnets incorporated for jdi_panel_unprepare, > dropped the returns (ref: panel-sharp-lq101r1sx01.c) and > for jdi_panel_prepare(panel_on) it does not return prematurely > and goes to poweroff if not success > * few dev_err's for panel_init >=20 > v9: > * function drm_panel_create_dsi_backlight made as static >=20 > v10: > * proper naming conventions and sequence wrt panel datasheet > (vddp-supply, iovcc-supply, > enable-gpios, reset-gpios, dcdc-en-gpios) > * GPIO_ACTIVE_LOW polarity logic for reset-gpios > --- > drivers/gpu/drm/panel/Kconfig | 11 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-jdi-lt070me05000.c | 532 +++++++++++++++++++= ++++++ > 3 files changed, 544 insertions(+) > create mode 100644 drivers/gpu/drm/panel/panel-jdi-lt070me05000.c Applied, thanks. Thierry --hK8Uo4Yp55NZU70L Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAABCAAGBQJX3BDqAAoJEN0jrNd/PrOhPN0P/0ZSsnrNchuivt7gIRJp23e9 4IjJ2a52CP5YkwSjsDpu/Il8N0/pS9IbVEXI3NaHnBEq+j+tI5o9jt1MONSjtiwO JEdQMF3TA3j+BpP0Lu0ogLrfraYJO9Dh5oRRNrfhFMhwQZc8KEXHN85cJGirtO6Z O6ugu/GoiQdRVygWC8ijRACpcHqgHxpNk/Kwjxg6EcneSxZkiruRjRia2i7j4Ncm vMAYogvJ7lMKgSyqDujs5NTXQ8LuVCGgGGjLO5zZMBW4mtjx6ZWuOXeM68prQ5ld R15dgr8kicnWHE2bUi8KF9E3GCpBnkyDXh9QZNO4azfqKVHYj4J2/WPtOeX94k0d nrT9m2rTNgtbIWXupM/olMKaXcCs+Q0h7ZdWO8X+QPf9Ft8WDMMsIcT3w2vSkHDO 20X7vOrWEmXe9760K2L6NU5/0PO1Jq8qhs4ZtR3sID80w8ZEZCZSWAlWL8lsrL2t tdnJiTRAOM2YcrtgWNiY6TNNaDZo94ofwMq9cTkilC+8k9K5rtUUsFWMGsbzjByX oe7dBXRQCxPZgZOnqDl2KUbq3qDhpycBDNU8cIsJmQKQrP7LeuCq6tGphWEE7TVt yfOhzUsu5krcgeBxU7r5KnWCK5q3dOoG7o9+Ur1Pp+V0WYzzGYegENORXSQW7BJ4 xKy/z66Jj94kjR+tt3l6 =ztY+ -----END PGP SIGNATURE----- --hK8Uo4Yp55NZU70L--