[PATCH v2] clk: probe common clock drivers earlier

[PATCH v2] clk: probe common clock drivers earlier

[Masahiro Yamada]

Several SoCs implement platform drivers for clocks rather than
CLK_OF_DECLARE().  Clocks should come earlier because they are
prerequisites for many of other drivers.  It will help to mitigate
EPROBE_DEFER issues.

Also, drop the comment since it does not look valuable.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

Changes in v2:
  - Move clk/ above dma/ since DMA drivers generally enable clk

 drivers/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/Makefile b/drivers/Makefile
index 8f5d076..ff39051 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -29,6 +29,8 @@ obj-$(CONFIG_SFI)		+= sfi/
 # was used and do nothing if so
 obj-$(CONFIG_PNP)		+= pnp/
 obj-y				+= amba/
+
+obj-y				+= clk/
 # Many drivers will want to use DMA so this has to be made available
 # really early.
 obj-$(CONFIG_DMADEVICES)	+= dma/
@@ -141,8 +143,6 @@ obj-$(CONFIG_VHOST_RING)	+= vhost/
 obj-$(CONFIG_VLYNQ)		+= vlynq/
 obj-$(CONFIG_STAGING)		+= staging/
 obj-y				+= platform/
-#common clk code
-obj-y				+= clk/
 
 obj-$(CONFIG_MAILBOX)		+= mailbox/
 obj-$(CONFIG_HWSPINLOCK)	+= hwspinlock/
-- 
1.9.1

Re: [PATCH v2] clk: probe common clock drivers earlier

[Masahiro Yamada]

Hi Stephen, Greg,


2016-05-20 23:49 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> Several SoCs implement platform drivers for clocks rather than
> CLK_OF_DECLARE().  Clocks should come earlier because they are
> prerequisites for many of other drivers.  It will help to mitigate
> EPROBE_DEFER issues.
>
> Also, drop the comment since it does not look valuable.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> Changes in v2:
>   - Move clk/ above dma/ since DMA drivers generally enable clk
>
>  drivers/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/Makefile b/drivers/Makefile
> index 8f5d076..ff39051 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -29,6 +29,8 @@ obj-$(CONFIG_SFI)             += sfi/
>  # was used and do nothing if so
>  obj-$(CONFIG_PNP)              += pnp/
>  obj-y                          += amba/
> +
> +obj-y                          += clk/
>  # Many drivers will want to use DMA so this has to be made available
>  # really early.
>  obj-$(CONFIG_DMADEVICES)       += dma/
> @@ -141,8 +143,6 @@ obj-$(CONFIG_VHOST_RING)    += vhost/
>  obj-$(CONFIG_VLYNQ)            += vlynq/
>  obj-$(CONFIG_STAGING)          += staging/
>  obj-y                          += platform/
> -#common clk code
> -obj-y                          += clk/
>
>  obj-$(CONFIG_MAILBOX)          += mailbox/
>  obj-$(CONFIG_HWSPINLOCK)       += hwspinlock/


What do you think of this patch?


Linus game me a positive comment:
https://lkml.org/lkml/2016/7/15/722



-- 
Best Regards
Masahiro Yamada

Re: [PATCH v2] clk: probe common clock drivers earlier

[Stephen Boyd]

On 09/16, Masahiro Yamada wrote:
> Hi Stephen, Greg,
> 
> 
> 2016-05-20 23:49 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> > Several SoCs implement platform drivers for clocks rather than
> > CLK_OF_DECLARE().  Clocks should come earlier because they are
> > prerequisites for many of other drivers.  It will help to mitigate
> > EPROBE_DEFER issues.
> >
> > Also, drop the comment since it does not look valuable.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > ---
> >
> > Changes in v2:
> >   - Move clk/ above dma/ since DMA drivers generally enable clk
> >
> >  drivers/Makefile | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/Makefile b/drivers/Makefile
> > index 8f5d076..ff39051 100644
> > --- a/drivers/Makefile
> > +++ b/drivers/Makefile
> > @@ -29,6 +29,8 @@ obj-$(CONFIG_SFI)             += sfi/
> >  # was used and do nothing if so
> >  obj-$(CONFIG_PNP)              += pnp/
> >  obj-y                          += amba/
> > +
> > +obj-y                          += clk/
> >  # Many drivers will want to use DMA so this has to be made available
> >  # really early.
> >  obj-$(CONFIG_DMADEVICES)       += dma/
> > @@ -141,8 +143,6 @@ obj-$(CONFIG_VHOST_RING)    += vhost/
> >  obj-$(CONFIG_VLYNQ)            += vlynq/
> >  obj-$(CONFIG_STAGING)          += staging/
> >  obj-y                          += platform/
> > -#common clk code
> > -obj-y                          += clk/
> >
> >  obj-$(CONFIG_MAILBOX)          += mailbox/
> >  obj-$(CONFIG_HWSPINLOCK)       += hwspinlock/
> 
> 
> What do you think of this patch?
> 

I assumed Greg would pick it up given that Mike already acked it.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH v2] clk: probe common clock drivers earlier

[Greg Kroah-Hartman]

On Fri, Sep 16, 2016 at 04:12:45PM -0700, Stephen Boyd wrote:
> On 09/16, Masahiro Yamada wrote:
> > Hi Stephen, Greg,
> > 
> > 
> > 2016-05-20 23:49 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> > > Several SoCs implement platform drivers for clocks rather than
> > > CLK_OF_DECLARE().  Clocks should come earlier because they are
> > > prerequisites for many of other drivers.  It will help to mitigate
> > > EPROBE_DEFER issues.
> > >
> > > Also, drop the comment since it does not look valuable.
> > >
> > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > > ---
> > >
> > > Changes in v2:
> > >   - Move clk/ above dma/ since DMA drivers generally enable clk
> > >
> > >  drivers/Makefile | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/Makefile b/drivers/Makefile
> > > index 8f5d076..ff39051 100644
> > > --- a/drivers/Makefile
> > > +++ b/drivers/Makefile
> > > @@ -29,6 +29,8 @@ obj-$(CONFIG_SFI)             += sfi/
> > >  # was used and do nothing if so
> > >  obj-$(CONFIG_PNP)              += pnp/
> > >  obj-y                          += amba/
> > > +
> > > +obj-y                          += clk/
> > >  # Many drivers will want to use DMA so this has to be made available
> > >  # really early.
> > >  obj-$(CONFIG_DMADEVICES)       += dma/
> > > @@ -141,8 +143,6 @@ obj-$(CONFIG_VHOST_RING)    += vhost/
> > >  obj-$(CONFIG_VLYNQ)            += vlynq/
> > >  obj-$(CONFIG_STAGING)          += staging/
> > >  obj-y                          += platform/
> > > -#common clk code
> > > -obj-y                          += clk/
> > >
> > >  obj-$(CONFIG_MAILBOX)          += mailbox/
> > >  obj-$(CONFIG_HWSPINLOCK)       += hwspinlock/
> > 
> > 
> > What do you think of this patch?
> > 
> 
> I assumed Greg would pick it up given that Mike already acked it.

I was going to take it?  It's not in my queue, sorry, can someone please
resend it with the acks and I will pick it up...

thanks,

greg k-h

Re: [PATCH v2] clk: probe common clock drivers earlier

[Masahiro Yamada]

Hi Greg,

2016-09-17 17:56 GMT+09:00 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> On Fri, Sep 16, 2016 at 04:12:45PM -0700, Stephen Boyd wrote:
>> On 09/16, Masahiro Yamada wrote:

>> >
>> >
>> > What do you think of this patch?
>> >
>>
>> I assumed Greg would pick it up given that Mike already acked it.
>
> I was going to take it?  It's not in my queue, sorry, can someone please
> resend it with the acks and I will pick it up...
>
> thanks,
>
> greg k-h



I did so with Michael's Acked-by:

https://patchwork.kernel.org/patch/9337959/


Thanks!




-- 
Best Regards
Masahiro Yamada