From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758202AbcIQI4F (ORCPT ); Sat, 17 Sep 2016 04:56:05 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:36263 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754405AbcIQI4D (ORCPT ); Sat, 17 Sep 2016 04:56:03 -0400 Date: Sat, 17 Sep 2016 10:56:06 +0200 From: Greg Kroah-Hartman To: Stephen Boyd Cc: Masahiro Yamada , linux-clk , Srinivas Kandagatla , Jay Sternberg , Jens Axboe , Linux Kernel Mailing List , Matias =?iso-8859-1?Q?Bj=F8rling?= , Krzysztof Kozlowski , Alan Tull , Alexander Shishkin , Valentin Rothberg , Michael Turquette , Linus Torvalds Subject: Re: [PATCH v2] clk: probe common clock drivers earlier Message-ID: <20160917085606.GA17799@kroah.com> References: <1463755793-9131-1-git-send-email-yamada.masahiro@socionext.com> <20160916231245.GX7243@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160916231245.GX7243@codeaurora.org> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 16, 2016 at 04:12:45PM -0700, Stephen Boyd wrote: > On 09/16, Masahiro Yamada wrote: > > Hi Stephen, Greg, > > > > > > 2016-05-20 23:49 GMT+09:00 Masahiro Yamada : > > > Several SoCs implement platform drivers for clocks rather than > > > CLK_OF_DECLARE(). Clocks should come earlier because they are > > > prerequisites for many of other drivers. It will help to mitigate > > > EPROBE_DEFER issues. > > > > > > Also, drop the comment since it does not look valuable. > > > > > > Signed-off-by: Masahiro Yamada > > > --- > > > > > > Changes in v2: > > > - Move clk/ above dma/ since DMA drivers generally enable clk > > > > > > drivers/Makefile | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/Makefile b/drivers/Makefile > > > index 8f5d076..ff39051 100644 > > > --- a/drivers/Makefile > > > +++ b/drivers/Makefile > > > @@ -29,6 +29,8 @@ obj-$(CONFIG_SFI) += sfi/ > > > # was used and do nothing if so > > > obj-$(CONFIG_PNP) += pnp/ > > > obj-y += amba/ > > > + > > > +obj-y += clk/ > > > # Many drivers will want to use DMA so this has to be made available > > > # really early. > > > obj-$(CONFIG_DMADEVICES) += dma/ > > > @@ -141,8 +143,6 @@ obj-$(CONFIG_VHOST_RING) += vhost/ > > > obj-$(CONFIG_VLYNQ) += vlynq/ > > > obj-$(CONFIG_STAGING) += staging/ > > > obj-y += platform/ > > > -#common clk code > > > -obj-y += clk/ > > > > > > obj-$(CONFIG_MAILBOX) += mailbox/ > > > obj-$(CONFIG_HWSPINLOCK) += hwspinlock/ > > > > > > What do you think of this patch? > > > > I assumed Greg would pick it up given that Mike already acked it. I was going to take it? It's not in my queue, sorry, can someone please resend it with the acks and I will pick it up... thanks, greg k-h