* [PATCH v2] clk: probe common clock drivers earlier
@ 2016-05-20 14:49 Masahiro Yamada
2016-09-16 7:53 ` Masahiro Yamada
0 siblings, 1 reply; 5+ messages in thread
From: Masahiro Yamada @ 2016-05-20 14:49 UTC (permalink / raw)
To: linux-clk
Cc: Masahiro Yamada, Srinivas Kandagatla, Jay Sternberg, Jens Axboe,
linux-kernel, Matias Bjørling, Krzysztof Kozlowski,
Alan Tull, Greg Kroah-Hartman, Alexander Shishkin,
Valentin Rothberg
Several SoCs implement platform drivers for clocks rather than
CLK_OF_DECLARE(). Clocks should come earlier because they are
prerequisites for many of other drivers. It will help to mitigate
EPROBE_DEFER issues.
Also, drop the comment since it does not look valuable.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
Changes in v2:
- Move clk/ above dma/ since DMA drivers generally enable clk
drivers/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/Makefile b/drivers/Makefile
index 8f5d076..ff39051 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -29,6 +29,8 @@ obj-$(CONFIG_SFI) += sfi/
# was used and do nothing if so
obj-$(CONFIG_PNP) += pnp/
obj-y += amba/
+
+obj-y += clk/
# Many drivers will want to use DMA so this has to be made available
# really early.
obj-$(CONFIG_DMADEVICES) += dma/
@@ -141,8 +143,6 @@ obj-$(CONFIG_VHOST_RING) += vhost/
obj-$(CONFIG_VLYNQ) += vlynq/
obj-$(CONFIG_STAGING) += staging/
obj-y += platform/
-#common clk code
-obj-y += clk/
obj-$(CONFIG_MAILBOX) += mailbox/
obj-$(CONFIG_HWSPINLOCK) += hwspinlock/
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] clk: probe common clock drivers earlier
2016-05-20 14:49 [PATCH v2] clk: probe common clock drivers earlier Masahiro Yamada
@ 2016-09-16 7:53 ` Masahiro Yamada
2016-09-16 23:12 ` Stephen Boyd
0 siblings, 1 reply; 5+ messages in thread
From: Masahiro Yamada @ 2016-09-16 7:53 UTC (permalink / raw)
To: linux-clk, Greg Kroah-Hartman, Stephen Boyd
Cc: Masahiro Yamada, Srinivas Kandagatla, Jay Sternberg, Jens Axboe,
Linux Kernel Mailing List, Matias Bjørling,
Krzysztof Kozlowski, Alan Tull, Alexander Shishkin,
Valentin Rothberg, Michael Turquette, Linus Torvalds
Hi Stephen, Greg,
2016-05-20 23:49 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> Several SoCs implement platform drivers for clocks rather than
> CLK_OF_DECLARE(). Clocks should come earlier because they are
> prerequisites for many of other drivers. It will help to mitigate
> EPROBE_DEFER issues.
>
> Also, drop the comment since it does not look valuable.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> Changes in v2:
> - Move clk/ above dma/ since DMA drivers generally enable clk
>
> drivers/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/Makefile b/drivers/Makefile
> index 8f5d076..ff39051 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -29,6 +29,8 @@ obj-$(CONFIG_SFI) += sfi/
> # was used and do nothing if so
> obj-$(CONFIG_PNP) += pnp/
> obj-y += amba/
> +
> +obj-y += clk/
> # Many drivers will want to use DMA so this has to be made available
> # really early.
> obj-$(CONFIG_DMADEVICES) += dma/
> @@ -141,8 +143,6 @@ obj-$(CONFIG_VHOST_RING) += vhost/
> obj-$(CONFIG_VLYNQ) += vlynq/
> obj-$(CONFIG_STAGING) += staging/
> obj-y += platform/
> -#common clk code
> -obj-y += clk/
>
> obj-$(CONFIG_MAILBOX) += mailbox/
> obj-$(CONFIG_HWSPINLOCK) += hwspinlock/
What do you think of this patch?
Linus game me a positive comment:
https://lkml.org/lkml/2016/7/15/722
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] clk: probe common clock drivers earlier
2016-09-16 7:53 ` Masahiro Yamada
@ 2016-09-16 23:12 ` Stephen Boyd
2016-09-17 8:56 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Boyd @ 2016-09-16 23:12 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-clk, Greg Kroah-Hartman, Srinivas Kandagatla, Jay Sternberg,
Jens Axboe, Linux Kernel Mailing List, Matias Bjørling,
Krzysztof Kozlowski, Alan Tull, Alexander Shishkin,
Valentin Rothberg, Michael Turquette, Linus Torvalds
On 09/16, Masahiro Yamada wrote:
> Hi Stephen, Greg,
>
>
> 2016-05-20 23:49 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> > Several SoCs implement platform drivers for clocks rather than
> > CLK_OF_DECLARE(). Clocks should come earlier because they are
> > prerequisites for many of other drivers. It will help to mitigate
> > EPROBE_DEFER issues.
> >
> > Also, drop the comment since it does not look valuable.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > ---
> >
> > Changes in v2:
> > - Move clk/ above dma/ since DMA drivers generally enable clk
> >
> > drivers/Makefile | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/Makefile b/drivers/Makefile
> > index 8f5d076..ff39051 100644
> > --- a/drivers/Makefile
> > +++ b/drivers/Makefile
> > @@ -29,6 +29,8 @@ obj-$(CONFIG_SFI) += sfi/
> > # was used and do nothing if so
> > obj-$(CONFIG_PNP) += pnp/
> > obj-y += amba/
> > +
> > +obj-y += clk/
> > # Many drivers will want to use DMA so this has to be made available
> > # really early.
> > obj-$(CONFIG_DMADEVICES) += dma/
> > @@ -141,8 +143,6 @@ obj-$(CONFIG_VHOST_RING) += vhost/
> > obj-$(CONFIG_VLYNQ) += vlynq/
> > obj-$(CONFIG_STAGING) += staging/
> > obj-y += platform/
> > -#common clk code
> > -obj-y += clk/
> >
> > obj-$(CONFIG_MAILBOX) += mailbox/
> > obj-$(CONFIG_HWSPINLOCK) += hwspinlock/
>
>
> What do you think of this patch?
>
I assumed Greg would pick it up given that Mike already acked it.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] clk: probe common clock drivers earlier
2016-09-16 23:12 ` Stephen Boyd
@ 2016-09-17 8:56 ` Greg Kroah-Hartman
2016-09-18 16:25 ` Masahiro Yamada
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2016-09-17 8:56 UTC (permalink / raw)
To: Stephen Boyd
Cc: Masahiro Yamada, linux-clk, Srinivas Kandagatla, Jay Sternberg,
Jens Axboe, Linux Kernel Mailing List, Matias Bjørling,
Krzysztof Kozlowski, Alan Tull, Alexander Shishkin,
Valentin Rothberg, Michael Turquette, Linus Torvalds
On Fri, Sep 16, 2016 at 04:12:45PM -0700, Stephen Boyd wrote:
> On 09/16, Masahiro Yamada wrote:
> > Hi Stephen, Greg,
> >
> >
> > 2016-05-20 23:49 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> > > Several SoCs implement platform drivers for clocks rather than
> > > CLK_OF_DECLARE(). Clocks should come earlier because they are
> > > prerequisites for many of other drivers. It will help to mitigate
> > > EPROBE_DEFER issues.
> > >
> > > Also, drop the comment since it does not look valuable.
> > >
> > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > > ---
> > >
> > > Changes in v2:
> > > - Move clk/ above dma/ since DMA drivers generally enable clk
> > >
> > > drivers/Makefile | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/Makefile b/drivers/Makefile
> > > index 8f5d076..ff39051 100644
> > > --- a/drivers/Makefile
> > > +++ b/drivers/Makefile
> > > @@ -29,6 +29,8 @@ obj-$(CONFIG_SFI) += sfi/
> > > # was used and do nothing if so
> > > obj-$(CONFIG_PNP) += pnp/
> > > obj-y += amba/
> > > +
> > > +obj-y += clk/
> > > # Many drivers will want to use DMA so this has to be made available
> > > # really early.
> > > obj-$(CONFIG_DMADEVICES) += dma/
> > > @@ -141,8 +143,6 @@ obj-$(CONFIG_VHOST_RING) += vhost/
> > > obj-$(CONFIG_VLYNQ) += vlynq/
> > > obj-$(CONFIG_STAGING) += staging/
> > > obj-y += platform/
> > > -#common clk code
> > > -obj-y += clk/
> > >
> > > obj-$(CONFIG_MAILBOX) += mailbox/
> > > obj-$(CONFIG_HWSPINLOCK) += hwspinlock/
> >
> >
> > What do you think of this patch?
> >
>
> I assumed Greg would pick it up given that Mike already acked it.
I was going to take it? It's not in my queue, sorry, can someone please
resend it with the acks and I will pick it up...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] clk: probe common clock drivers earlier
2016-09-17 8:56 ` Greg Kroah-Hartman
@ 2016-09-18 16:25 ` Masahiro Yamada
0 siblings, 0 replies; 5+ messages in thread
From: Masahiro Yamada @ 2016-09-18 16:25 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Stephen Boyd, linux-clk, Srinivas Kandagatla, Jay Sternberg,
Jens Axboe, Linux Kernel Mailing List, Matias Bjørling,
Krzysztof Kozlowski, Alan Tull, Alexander Shishkin,
Valentin Rothberg, Michael Turquette, Linus Torvalds
Hi Greg,
2016-09-17 17:56 GMT+09:00 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> On Fri, Sep 16, 2016 at 04:12:45PM -0700, Stephen Boyd wrote:
>> On 09/16, Masahiro Yamada wrote:
>> >
>> >
>> > What do you think of this patch?
>> >
>>
>> I assumed Greg would pick it up given that Mike already acked it.
>
> I was going to take it? It's not in my queue, sorry, can someone please
> resend it with the acks and I will pick it up...
>
> thanks,
>
> greg k-h
I did so with Michael's Acked-by:
https://patchwork.kernel.org/patch/9337959/
Thanks!
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-09-18 16:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-20 14:49 [PATCH v2] clk: probe common clock drivers earlier Masahiro Yamada
2016-09-16 7:53 ` Masahiro Yamada
2016-09-16 23:12 ` Stephen Boyd
2016-09-17 8:56 ` Greg Kroah-Hartman
2016-09-18 16:25 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox