From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752945AbcIQQYN (ORCPT ); Sat, 17 Sep 2016 12:24:13 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:33803 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751296AbcIQQYE (ORCPT ); Sat, 17 Sep 2016 12:24:04 -0400 Date: Sat, 17 Sep 2016 19:24:00 +0300 From: Mike Krinkin To: mingo@kernel.org, tglx@linutronix.de, hpa@zytor.com, ricardo.neri-calderon@linux.intel.com, ard.biesheuvel@linaro.org, matt@codeblueprint.co.uk, pjones@redhat.com, scott.lawson@intel.com Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Subject: Cannot load linux after recent efi-related changes Message-ID: <20160917162357.GA4122@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, after commit 3dad6f7f6975 ("x86/efi: Defer efi_esrt_init until after memblock_x86_fill") kernel hits BUG_ON __efi_enter_virtual_mode because efi.systab is NULL. With older kernel versions i face the problem with efi_mem_reserve described in the commit. AFAICS, get_systab_virt_addr called from efi_map_regions should set efi.systab, but i dumped memory desciptors in efi_map_regions and apparently none of them describes region that contains efi_phys.systab, so efi.systab remains unset.