From: Omar Sandoval <osandov@osandov.com>
To: Jens Axboe <axboe@fb.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com, Alexei Starovoitov <ast@fb.com>
Subject: Re: [PATCH] sbitmap: don't update the allocation hint on clear after resize
Date: Sat, 17 Sep 2016 12:49:27 -0700 [thread overview]
Message-ID: <20160917194927.GA28432@vader> (raw)
In-Reply-To: <227b6d24-8500-4ec9-5999-fd83f7221b8a@fb.com>
On Sat, Sep 17, 2016 at 01:39:59PM -0600, Jens Axboe wrote:
> On 09/17/2016 01:20 PM, Omar Sandoval wrote:
> > From: Omar Sandoval <osandov@fb.com>
> >
> > If we have a bunch of high-numbered bits allocated and then we resize
> > the struct sbitmap_queue, when those bits get cleared, we'll update the
> > hint and then have to re-randomize it repeatedly. Avoid that by checking
> > that the cleared bit is still a valid hint. No measurable performance
> > difference in the common case.
> >
> > Signed-off-by: Omar Sandoval <osandov@fb.com>
> > ---
> > Jens,
> >
> > Small tweak to patch 6 that occurred to me after I sent the series out.
> > Feel free to fold it in to patch 6 or apply it separately as you see
> > fit.
>
> No worries. I can't fold since the series was already applied, so I just
> added the extra patch.
>
Okay with me, thanks!
--
Omar
prev parent reply other threads:[~2016-09-17 19:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-17 8:28 [PATCH v4 0/6] blk-mq: generalization and bug fixes for tag allocation Omar Sandoval
2016-09-17 8:28 ` [PATCH v4 1/6] blk-mq: abstract tag allocation out into sbitmap library Omar Sandoval
2016-09-17 8:28 ` [PATCH v4 2/6] sbitmap: allocate wait queues on a specific node Omar Sandoval
2016-09-17 8:28 ` [PATCH v4 3/6] sbitmap: push per-cpu last_tag into sbitmap_queue Omar Sandoval
2016-09-17 8:28 ` [PATCH v4 4/6] sbitmap: push alloc policy " Omar Sandoval
2016-09-17 8:28 ` [PATCH v4 5/6] sbitmap: randomize initial alloc_hint values Omar Sandoval
2016-09-17 8:28 ` [PATCH v4 6/6] sbitmap: re-initialize allocation hints after resize Omar Sandoval
2016-09-17 14:42 ` [PATCH v4 0/6] blk-mq: generalization and bug fixes for tag allocation Jens Axboe
2016-09-17 19:20 ` [PATCH] sbitmap: don't update the allocation hint on clear after resize Omar Sandoval
2016-09-17 19:39 ` Jens Axboe
2016-09-17 19:49 ` Omar Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160917194927.GA28432@vader \
--to=osandov@osandov.com \
--cc=ast@fb.com \
--cc=axboe@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox