From: Shawn Guo <shawnguo@kernel.org>
To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>,
Guenter Roeck <linux@roeck-us.net>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Linus Walleij" <linus.walleij@linaro.org>
Subject: Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift gpio_mxc_init() to subsys_initcall level'
Date: Sun, 18 Sep 2016 08:08:45 +0800 [thread overview]
Message-ID: <20160918000845.GA15478@tiger> (raw)
In-Reply-To: <99993063-6692-0870-12fa-64cf13d507f6@mentor.com>
Hi Guenter,
On Thu, Sep 15, 2016 at 04:35:04PM +0300, Vladimir Zapolskiy wrote:
> The proper fix in this particular case should be like this one:
>
Does Vladimir's patch below fix your problem?
Shawn
> diff --git a/arch/arm/mach-imx/mach-kzm_arm11_01.c b/arch/arm/mach-imx/mach-kzm_arm11_01.c
> index 31df4361996f..8288acfe7221 100644
> --- a/arch/arm/mach-imx/mach-kzm_arm11_01.c
> +++ b/arch/arm/mach-imx/mach-kzm_arm11_01.c
> @@ -245,13 +245,17 @@ static void __init kzm_board_init(void)
> mxc_iomux_setup_multiple_pins(kzm_pins,
> ARRAY_SIZE(kzm_pins), "kzm");
> - kzm_init_ext_uart();
> - kzm_init_smsc9118();
> kzm_init_imx_uart();
> pr_info("Clock input source is 26MHz\n");
> }
> +static void __init kzm_late_init(void)
> +{
> + kzm_init_ext_uart();
> + kzm_init_smsc9118();
> +}
> +
> /*
> * This structure defines static mappings for the kzm-arm11-01 board.
> */
> @@ -291,5 +295,6 @@ MACHINE_START(KZM_ARM11_01, "Kyoto Microcomputer Co., Ltd. KZM-ARM11-01")
> .init_irq = mx31_init_irq,
> .init_time = kzm_timer_init,
> .init_machine = kzm_board_init,
> + .init_late = kzm_late_init,
> .restart = mxc_restart,
> MACHINE_END
> --
next prev parent reply other threads:[~2016-09-18 0:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 3:20 Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift gpio_mxc_init() to subsys_initcall level' Guenter Roeck
2016-09-14 7:19 ` Linus Walleij
2016-09-14 14:33 ` Guenter Roeck
2016-09-15 12:19 ` Linus Walleij
2016-09-15 13:18 ` Vladimir Zapolskiy
2016-09-15 13:45 ` Vladimir Zapolskiy
2016-09-15 13:55 ` Linus Walleij
2016-09-15 13:18 ` Vladimir Zapolskiy
2016-09-15 13:35 ` Vladimir Zapolskiy
2016-09-15 14:23 ` Uwe Kleine-König
2016-09-15 14:35 ` Guenter Roeck
2016-09-15 14:46 ` Uwe Kleine-König
2016-09-16 2:24 ` Guenter Roeck
2016-09-18 0:08 ` Shawn Guo [this message]
2016-09-18 0:59 ` Guenter Roeck
2016-09-18 11:24 ` Linus Walleij
2016-09-20 12:55 ` Shawn Guo
2016-09-20 13:53 ` Vladimir Zapolskiy
2016-09-20 14:18 ` Shawn Guo
2016-09-20 21:35 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160918000845.GA15478@tiger \
--to=shawnguo@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vladimir_zapolskiy@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).