[PATCH] sysfs print name of undiscoverable attribute group as well

[PATCH] sysfs print name of undiscoverable attribute group as well

[Johannes Thumshirn]

Print the name of an undiscoverable attribute group as well, not just
the pointer's address.

Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
---
 fs/sysfs/group.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/sysfs/group.c b/fs/sysfs/group.c
index dc1358b..b1a3557 100644
--- a/fs/sysfs/group.c
+++ b/fs/sysfs/group.c
@@ -233,8 +233,8 @@ void sysfs_remove_group(struct kobject *kobj,
 		kn = kernfs_find_and_get(parent, grp->name);
 		if (!kn) {
 			WARN(!kn, KERN_WARNING
-			     "sysfs group %p not found for kobject '%s'\n",
-			     grp, kobject_name(kobj));
+			     "sysfs group '%s' %p not found for kobject '%s'\n",
+			     grp->name, grp, kobject_name(kobj));
 			return;
 		}
 	} else {
-- 
1.8.5.6

Re: [PATCH] sysfs print name of undiscoverable attribute group as well

[Greg KH]

On Thu, Sep 15, 2016 at 09:44:06PM +0200, Johannes Thumshirn wrote:
> Print the name of an undiscoverable attribute group as well, not just
> the pointer's address.

Shouldn't we just drop the pointer address and use the name?  It's bad
form to be printing kernel addresses to the syslog these days given that
it is a security information leak :(

thanks,

greg k-h

Re: [PATCH] sysfs print name of undiscoverable attribute group as well

[Johannes Thumshirn]

On Sun, Sep 18, 2016 at 09:36:02AM +0200, Greg KH wrote:
> On Thu, Sep 15, 2016 at 09:44:06PM +0200, Johannes Thumshirn wrote:
> > Print the name of an undiscoverable attribute group as well, not just
> > the pointer's address.
> 
> Shouldn't we just drop the pointer address and use the name?  It's bad
> form to be printing kernel addresses to the syslog these days given that
> it is a security information leak :(

Probably yes. Given it's not etremely helpful when debugging either
I'll send a v2 with the address dropped.

Thanks,
	Johannes

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Re: [PATCH] sysfs print name of undiscoverable attribute group as well

[Johannes Thumshirn]

On Sun, Sep 18, 2016 at 09:36:02AM +0200, Greg KH wrote:
> On Thu, Sep 15, 2016 at 09:44:06PM +0200, Johannes Thumshirn wrote:
> > Print the name of an undiscoverable attribute group as well, not just
> > the pointer's address.
> 
> Shouldn't we just drop the pointer address and use the name?  It's bad
> form to be printing kernel addresses to the syslog these days given that
> it is a security information leak :(

Yes probably and it isn't that much of a help when debugging
either. I'll resend a v2.

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850