From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758224AbcIRKZb (ORCPT ); Sun, 18 Sep 2016 06:25:31 -0400 Received: from cassarossa.samfundet.no ([193.35.52.29]:56111 "EHLO cassarossa.samfundet.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754739AbcIRKZW (ORCPT ); Sun, 18 Sep 2016 06:25:22 -0400 X-Greylist: delayed 2311 seconds by postgrey-1.27 at vger.kernel.org; Sun, 18 Sep 2016 06:25:22 EDT Date: Sun, 18 Sep 2016 11:46:43 +0200 From: Hans-Christian Noren Egtvedt To: Guenter Roeck Cc: =?iso-8859-1?Q?H=E5vard?= Skinnemoen , Linux Kernel , Al Viro Subject: Re: [PATCH] avr32: fix 'undefined reference to `___copy_from_user' Message-ID: <20160918094643.GA25728@samfundet.no> References: <1474124194-17763-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Around Sat 17 Sep 2016 13:09:17 -0700 or thereabout, Guenter Roeck wrote: > On 09/17/2016 09:52 AM, Håvard Skinnemoen wrote: >>On Sat, Sep 17, 2016 at 7:56 AM, Guenter Roeck wrote: >>>avr32 builds fail with: >>> >>>arch/avr32/kernel/built-in.o: In function `arch_ptrace': >>>(.text+0x650): undefined reference to `___copy_from_user' >>>arch/avr32/kernel/built-in.o:(___ksymtab+___copy_from_user+0x0): undefined >>>reference to `___copy_from_user' >>>kernel/built-in.o: In function `proc_doulongvec_ms_jiffies_minmax': >>>(.text+0x5dd8): undefined reference to `___copy_from_user' >>>kernel/built-in.o: In function `proc_dointvec_minmax_sysadmin': >>>sysctl.c:(.text+0x6174): undefined reference to `___copy_from_user' >>>kernel/built-in.o: In function `ptrace_has_cap': >>>ptrace.c:(.text+0x69c0): undefined reference to `___copy_from_user' >>>kernel/built-in.o:ptrace.c:(.text+0x6b90): more undefined references to >>>`___copy_from_user' follow >>> >>>Fixes: 8630c32275ba ("avr32: fix copy_from_user()") >>>Cc: Al Viro >>>Signed-off-by: Guenter Roeck >> >>Right, gmail loves HTML. Let me try this again... >> >>Acked-by: Havard Skinnemoen Acked-by: Hans-Christian Noren Egtvedt >>Thanks! >> > You are welcome ... I'll wait until tomorrow to see if Al wants to send this > patch and the patch for the openrisc failure to Linus; if I don't hear back, > I'll do it myself. Thanks, I have no other fixes for AVR32. But let me know if you want me to push it through linux-avr32. Why did not Al add Håvard/me to CC in the first place? That way we might have avoided this build break in the first place? -- Best regards, Hans-Christian Noren Egtvedt