From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758903AbcIRSSt (ORCPT ); Sun, 18 Sep 2016 14:18:49 -0400 Received: from andre.telenet-ops.be ([195.130.132.53]:57514 "EHLO andre.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754847AbcIRSS1 (ORCPT ); Sun, 18 Sep 2016 14:18:27 -0400 Date: Sun, 18 Sep 2016 20:18:19 +0200 From: Sam Van Den Berge To: Sylwester Nawrocki Cc: vinod.koul@intel.com, dmaengine@vger.kernel.org, k.kozlowski@samsung.com, kgene@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] dmaengine: s3c24xx: Add dma_slave_map for s3c2440 devices Message-ID: <20160918181819.GA28721@sam-MacBookPro> References: <1473968506-4150-1-git-send-email-sam.van.den.berge@telenet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 16, 2016 at 01:00:12PM +0200, Sylwester Nawrocki wrote: > On 09/15/2016 09:41 PM, Sam Van Den Berge wrote: > > @@ -445,10 +446,44 @@ static struct s3c24xx_dma_channel s3c2440_dma_channels[DMACH_MAX] = { > > [DMACH_USB_EP4] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(4, 3), }, > > }; > > > > +static const struct dma_slave_map s3c2440_dma_slave_map[] = { > > + /* TODO: DMACH_XD0 */ > > + /* TODO: DMACH_XD1 */ > > + { "3c2440-sdi", "rx-tx", (void *)DMACH_SDI }, > > Thanks for the patch, still device name needs to be changed here > to "s3c2440-sdi". Thanks for spotting this! I guess I was too focused on the "rx-tx" part that I totally missed the missing leading "s". I will fix this in v3. Sam.