From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761082AbcIRURz (ORCPT ); Sun, 18 Sep 2016 16:17:55 -0400 Received: from down.free-electrons.com ([37.187.137.238]:43409 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753428AbcIRURt (ORCPT ); Sun, 18 Sep 2016 16:17:49 -0400 Date: Sun, 18 Sep 2016 22:17:47 +0200 From: Maxime Ripard To: Danny Milosavljevic Cc: Mark Brown , Chen-Yu Tsai , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Jaroslav Kysela , Takashi Iwai , Liam Girdwood , linux-sunxi@googlegroups.com Subject: Re: [PATCH v4 2/3] ASoC: rename some sun7i-only registers Message-ID: <20160918201747.GL17518@lukather> References: <20160915163630.18026-1-dannym@scratchpost.org> <20160915163630.18026-3-dannym@scratchpost.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="FnOKg9Ah4tDwTfQS" Content-Disposition: inline In-Reply-To: <20160915163630.18026-3-dannym@scratchpost.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --FnOKg9Ah4tDwTfQS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 15, 2016 at 06:36:29PM +0200, Danny Milosavljevic wrote: > ASoC: sun4i-codec: Some of the registers are sun7i-only. That line is useless, you already have the commit title. >=20 > Therefore rename "SUN4I_CODEC_SYS_VERI" to "SUN7I_CODEC_AC_DAC_CAL" and > rename "SUN4I_CODEC_AC_MIC_PHONE_CAL" to "SUN7I_CODEC_AC_MIC_PHONE_CAL". And removing it, you could make a real sentence, like: Some of the registers defined in the driver are only usable on the A20. Rename these registers. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --FnOKg9Ah4tDwTfQS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJX3vZrAAoJEBx+YmzsjxAgXLoP/jQ3mpdWoWUI9eh2eTILwcHC FODiFGYRMuBMKcyPXvDY3JJbsRSzFGa5GBtVgDv8yS4JcIojVgagoDaM8HLoU/3j K7UH7h4R6dpZ8vLDVkCQE6iEE2nRc6LL94uZO9FwouJ4VJZY25rYsCYvW7HKq5eC 55O/lo3aGzdnZsPQdv3lf+5i0ir2GTUsNC2ChbjpCXt3LR91PZyoLMNLFsyxOzdZ E7VsmrNjVEZAcGoUqtRQOkKQeMwWpHVA/et2nwDez6hnn9oNpPx63irkU6IqLFdQ 9/Yzlbc2yKzhOk2gyk+P0OPOzTgoCHrvHkIeZ7WWOk+2XeQ71YYJaFiNtBW23ZEb E/Vzlpz0rXohAuW6vF/e4f3PVoG175F4ertCujadDrWGpfb5xauxlO0+4/JERD7L msm7gB9RE6KNpIBPty/Q7y0OepiTZ9+KeiEyVOd9iSjOozkGPXizTW4Wgu8e/LWo EEVo3w41osot9ucYvmQt8QQOMGmO/nXfCOFq1JE2ZR3HSniei5R8lBzECm2cEJxL 2ySQd5sBPU2uJY2Tebc1PyUxWFf6Cn1f7pRGGinZVvXTpJsmXKsdroOG64nlqnA9 ittauFLK4wSoPvmgbmRnfQ6EQuOfL00+Q8a1Dof9cvDggEhG96uZeE+GaD9amAAd 1YuHI8qIala4mptXKbVi =xzYe -----END PGP SIGNATURE----- --FnOKg9Ah4tDwTfQS--