linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	David Howells <dhowells@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH] rbtree_augmented: fix implicit rcu assign pointer dependency
Date: Sun, 18 Sep 2016 17:52:41 -0400	[thread overview]
Message-ID: <20160918215241.23268-1-paul.gortmaker@windriver.com> (raw)

To fix:

In file included from include/linux/interval_tree_generic.h:22:0,
                 from lib/interval_tree.c:2:
include/linux/rbtree_augmented.h: In function ‘__rb_change_child_rcu’:
include/linux/rbtree_augmented.h:139:4: error: implicit declaration of function ‘rcu_assign_pointer’ [-Werror=implicit-function-declaration]
    rcu_assign_pointer(parent->rb_left, new);

...which shows up on some -rt builds once the rb_replace_node_rcu was
added.  Since rcu_assign_pointer is clearly used, just add the header
for it to the file in question.

Fixes: c1adf20052d80 ("Introduce rb_replace_node_rcu()")
Cc: David Howells <dhowells@redhat.com>
Cc: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

diff --git a/include/linux/rbtree_augmented.h b/include/linux/rbtree_augmented.h
index d076183e49be..36bfb4dd57ae 100644
--- a/include/linux/rbtree_augmented.h
+++ b/include/linux/rbtree_augmented.h
@@ -26,6 +26,7 @@
 
 #include <linux/compiler.h>
 #include <linux/rbtree.h>
+#include <linux/rcupdate.h>
 
 /*
  * Please note - only struct rb_augment_callbacks and the prototypes for
-- 
2.5.0

                 reply	other threads:[~2016-09-18 21:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160918215241.23268-1-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).