From: Johannes Thumshirn <jthumshirn@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <keith.busch@intel.com>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
Jens Axboe <axboe@fb.com>, Andy Lutomirski <luto@kernel.org>,
J Freyensee <james_p_freyensee@linux.intel.com>
Subject: Re: [PATCH v3 1/3] nvme/scsi: Remove power management support
Date: Mon, 19 Sep 2016 09:59:39 +0200 [thread overview]
Message-ID: <20160919075939.eoycfbur4zchf3m3@linux-x5ow.site> (raw)
In-Reply-To: <20160916142500.GA9578@lst.de>
On Fri, Sep 16, 2016 at 04:25:00PM +0200, Christoph Hellwig wrote:
> On Fri, Sep 16, 2016 at 10:33:02AM -0400, Keith Busch wrote:
> > On Fri, Sep 16, 2016 at 10:33:33AM +0200, Christoph Hellwig wrote:
> > > On Thu, Sep 15, 2016 at 10:24:19PM -0700, Andy Lutomirski wrote:
> > > > Since this code appears to be useless, just delete it.
> > >
> > > Yes, please!
> >
> > For a future patch, any objection to deleting the whole file? :)
>
> Not from me for sure, but I fear some users might be using it after all.
IIRC there was some issues with openSUSE and pre NVMe 1.2 Adapters
without the scsi translation.
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2016-09-19 7:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 5:24 [PATCH v3 0/3] nvme power saving Andy Lutomirski
2016-09-16 5:24 ` [PATCH v3 1/3] nvme/scsi: Remove power management support Andy Lutomirski
2016-09-16 8:33 ` Christoph Hellwig
2016-09-16 14:33 ` Keith Busch
2016-09-16 14:25 ` Christoph Hellwig
2016-09-19 7:59 ` Johannes Thumshirn [this message]
2016-09-16 23:33 ` J Freyensee
2016-09-16 5:24 ` [PATCH v3 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set_features() Andy Lutomirski
2016-09-16 8:41 ` Christoph Hellwig
2016-09-16 15:13 ` Andy Lutomirski
2016-09-16 15:34 ` Jens Axboe
2016-09-16 5:24 ` [PATCH v3 3/3] nvme: Enable autonomous power state transitions Andy Lutomirski
2016-09-16 8:42 ` Christoph Hellwig
2016-09-16 15:14 ` Andy Lutomirski
2016-09-16 16:51 ` Christoph Hellwig
2016-09-16 15:38 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919075939.eoycfbur4zchf3m3@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=james_p_freyensee@linux.intel.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=luto@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).