From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1759868AbcISH7v (ORCPT <rfc822;w@1wt.eu>);
        Mon, 19 Sep 2016 03:59:51 -0400
Received: from mx2.suse.de ([195.135.220.15]:33781 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751914AbcISH7m (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 19 Sep 2016 03:59:42 -0400
Date: Mon, 19 Sep 2016 09:59:39 +0200
From: Johannes Thumshirn <jthumshirn@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <keith.busch@intel.com>, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org, Jens Axboe <axboe@fb.com>,
        Andy Lutomirski <luto@kernel.org>,
        J Freyensee <james_p_freyensee@linux.intel.com>
Subject: Re: [PATCH v3 1/3] nvme/scsi: Remove power management support
Message-ID: <20160919075939.eoycfbur4zchf3m3@linux-x5ow.site>
References: <cover.1474002926.git.luto@kernel.org>
 <714df91022b06c6799afb315962769f22b8ab9f4.1474002926.git.luto@kernel.org>
 <20160916083333.GB2415@lst.de>
 <20160916143301.GB1852@localhost.localdomain>
 <20160916142500.GA9578@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20160916142500.GA9578@lst.de>
User-Agent: Mutt/1.6.2-neo (2016-06-11)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 16, 2016 at 04:25:00PM +0200, Christoph Hellwig wrote:
> On Fri, Sep 16, 2016 at 10:33:02AM -0400, Keith Busch wrote:
> > On Fri, Sep 16, 2016 at 10:33:33AM +0200, Christoph Hellwig wrote:
> > > On Thu, Sep 15, 2016 at 10:24:19PM -0700, Andy Lutomirski wrote:
> > > > Since this code appears to be useless, just delete it.
> > > 
> > > Yes, please!
> > 
> > For a future patch, any objection to deleting the whole file? :)
> 
> Not from me for sure, but I fear some users might be using it after all.

IIRC there was some issues with openSUSE and pre NVMe 1.2 Adapters
without the scsi translation.

Byte,
	Johannes
-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850