From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938417AbcISISj (ORCPT ); Mon, 19 Sep 2016 04:18:39 -0400 Received: from down.free-electrons.com ([37.187.137.238]:51510 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S936397AbcISISg (ORCPT ); Mon, 19 Sep 2016 04:18:36 -0400 Date: Mon, 19 Sep 2016 10:18:24 +0200 From: Maxime Ripard To: Icenowy Zheng Cc: Rob Herring , Russell King , Chen-Yu Tsai , Mark Rutland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/2] ARM: dts: sun8i: add pinmux for UART1 at PG Message-ID: <20160919081824.GB8719@lukather> References: <20160916151642.27907-1-icenowy@aosc.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3lcZGd9BuhuYXNfi" Content-Disposition: inline In-Reply-To: <20160916151642.27907-1-icenowy@aosc.xyz> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --3lcZGd9BuhuYXNfi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Sep 16, 2016 at 11:16:41PM +0800, Icenowy Zheng wrote: > The UART1 at PG (PG6, PG7, PG8, PG9) is, in the Allwinner's reference > tablet design of A23/33, used to connect to UART Bluetooth cards. >=20 > Add the pinmux for it. >=20 > Signed-off-by: Icenowy Zheng > --- > This patch is splited in v4. >=20 > arch/arm/boot/dts/sun8i-a23-a33.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi b/arch/arm/boot/dts/sun= 8i-a23-a33.dtsi > index 7e05e09..c340885 100644 > --- a/arch/arm/boot/dts/sun8i-a23-a33.dtsi > +++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi > @@ -361,6 +361,20 @@ > allwinner,pull =3D ; > }; > =20 > + uart1_pins_a: uart1@0 { > + allwinner,pins =3D "PG6", "PG7"; > + allwinner,function =3D "uart1"; > + allwinner,drive =3D ; > + allwinner,pull =3D ; > + }; > + > + uart1_pins_cts_rts_a: uart1-cts-rts@0 { > + allwinner,pins =3D "PG8", "PG9"; > + allwinner,function =3D "uart1"; > + allwinner,drive =3D ; > + allwinner,pull =3D ; > + }; > + It turns out the allwinner,drive and allwinner,pull properties are optionnal. I removed them, and applied that patch. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --3lcZGd9BuhuYXNfi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJX359QAAoJEBx+YmzsjxAg3vsP/0HEB+Ac2RZhrwDua5YoI+7V rTcEgUpqI+IzHxGOYgz8WMwE6stmZTp2j9+nW5+LQbxSMIVkD9lT9MfTFzfKCbHN mJb7xipkEM8W9LLyPrYULclKO+GNwkLn8Hdwh402BhlppDID37Sa1SIuj3LnX077 6ko0YCXKN77E9I99TP1uVChapPw8Kr4NJEo31rXs2U9khT6u88RuBkQur159A9o2 46gBaPl722BFBQbemEBX9VEVm2TZSI78OuVjcNuS+Isehp4+sNTQae49tfuvvjg/ 7noLk75wGvyOr+irv1K+NiEZ8NbzuOyRc1AkWlQ96NzcGRwlWbbgErtLZDCVo+lF E6qbAEoR+fFF6xUfFsgCvGaR2Kh7MSnQ7VRLpM9SVjeoa4Z9WWdi+8RiaOK4Scnw ykiuFYGMkneePVa9uEL/LProTErygSjvUkG2zScFy6hXC9HoXofkulWI8N7BU9Qv glbg9M2q/8MBBP+DZydZKp7SWEq8yrmZQUnSMQDYcj+lT6U0YoIslSocJpKsUOgT xFvQ4QkNemwhq3xutjEoF38VYlZijGgcfGGiAAVPAMb4YMY0Ocw13DYBH+OQg2EA e/rulEsj+XB96ewm4BRG6J7vyYDFoy6OXOuyh7OMV0hCYj55EyM9VcIuKkNw28JF RekuSlQjOTXP1freatHZ =c9LJ -----END PGP SIGNATURE----- --3lcZGd9BuhuYXNfi--