From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753127AbcISJZc (ORCPT ); Mon, 19 Sep 2016 05:25:32 -0400 Received: from down.free-electrons.com ([37.187.137.238]:54340 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751129AbcISJZY (ORCPT ); Mon, 19 Sep 2016 05:25:24 -0400 Date: Mon, 19 Sep 2016 11:25:22 +0200 From: Boris Brezillon To: Andy Yan Cc: heiko@sntech.de, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization Message-ID: <20160919112522.5567b882@bbrezillon> In-Reply-To: <1474274696-28090-1-git-send-email-andy.yan@rock-chips.com> References: <1474274639-27768-1-git-send-email-andy.yan@rock-chips.com> <1474274696-28090-1-git-send-email-andy.yan@rock-chips.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Sep 2016 16:44:56 +0800 Andy Yan wrote: > The current rk3066a based boards(Rayeager, Bqcurie2, Marsboard) use > pwm modulate vdd_logic voltage, but the pwm is default disabled and > the pwm pin acts as a gpio before pwm regulator probed, so the pwm > regulator driver will get a zero dutycycle at probe time, so change > the initial dutycycle to zero to match pwm_regulator_init_state check. > > Signed-off-by: Andy Yan > > --- > > arch/arm/boot/dts/rk3066a-bqcurie2.dts | 2 +- > arch/arm/boot/dts/rk3066a-marsboard.dts | 2 +- > arch/arm/boot/dts/rk3066a-rayeager.dts | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/rk3066a-bqcurie2.dts b/arch/arm/boot/dts/rk3066a-bqcurie2.dts > index bc674ee..618450d 100644 > --- a/arch/arm/boot/dts/rk3066a-bqcurie2.dts > +++ b/arch/arm/boot/dts/rk3066a-bqcurie2.dts > @@ -61,7 +61,7 @@ > regulator-min-microvolt = <1200000>; > regulator-max-microvolt = <1200000>; > regulator-always-on; > - voltage-table = <1000000 100>, > + voltage-table = <1000000 0>, > <1200000 42>; So, it seems you are reversing the PWM polarity here. Are you sure you shouldn't change the 2nd entry of this table (<1200000 58>)? > status = "okay"; > }; > diff --git a/arch/arm/boot/dts/rk3066a-marsboard.dts b/arch/arm/boot/dts/rk3066a-marsboard.dts > index a2b763e..ddc680b 100644 > --- a/arch/arm/boot/dts/rk3066a-marsboard.dts > +++ b/arch/arm/boot/dts/rk3066a-marsboard.dts > @@ -59,7 +59,7 @@ > regulator-min-microvolt = <1200000>; > regulator-max-microvolt = <1200000>; > regulator-always-on; > - voltage-table = <1000000 100>, > + voltage-table = <1000000 0>, > <1200000 42>; > status = "okay"; > }; > diff --git a/arch/arm/boot/dts/rk3066a-rayeager.dts b/arch/arm/boot/dts/rk3066a-rayeager.dts > index 2536b3a..30aee99 100644 > --- a/arch/arm/boot/dts/rk3066a-rayeager.dts > +++ b/arch/arm/boot/dts/rk3066a-rayeager.dts > @@ -84,7 +84,7 @@ > regulator-min-microvolt = <1200000>; > regulator-max-microvolt = <1200000>; > regulator-always-on; > - voltage-table = <1000000 100>, > + voltage-table = <1000000 0>, > <1200000 42>; > status = "okay"; > };