From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753038AbcISR7u (ORCPT ); Mon, 19 Sep 2016 13:59:50 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:32871 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750898AbcISR7t (ORCPT ); Mon, 19 Sep 2016 13:59:49 -0400 Date: Mon, 19 Sep 2016 10:59:46 -0700 From: Omar Sandoval To: Alexander Gordeev Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH 10/14] blk-mq: Uninit hardware context in order reverse to init Message-ID: <20160919175946.GC21803@vader> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 18, 2016 at 09:37:20AM +0200, Alexander Gordeev wrote: > CC: linux-block@vger.kernel.org > Signed-off-by: Alexander Gordeev > --- > block/blk-mq.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/block/blk-mq.c b/block/blk-mq.c > index cd32a08..c589096 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -2013,12 +2013,13 @@ static void blk_mq_realloc_hw_ctxs(struct blk_mq_tag_set *set, > struct blk_mq_hw_ctx *hctx = hctxs[j]; > > if (hctx) { > + kobject_put(&hctx->kobj); > + > if (hctx->tags) { > blk_mq_free_rq_map(set, hctx->tags, j); > set->tags[j] = NULL; > } > blk_mq_exit_hctx(q, set, hctx, j); > - kobject_put(&hctx->kobj); > hctxs[j] = NULL; > } > } Oh, this fixes my comment from the last one, but it should be folded in to be bisect-safe. -- Omar