public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rabin Vincent <rabin@rab.in>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Stephane Eranian <eranian@google.com>,
	Vince Weaver <vincent.weaver@maine.edu>,
	LKML <linux-kernel@vger.kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Ingo Molnar <mingo@kernel.org>, Kees Cook <keescook@chromium.org>,
	Vegard Nossum <vegard.nossum@gmail.com>
Subject: Re: [PATCH v3] scripts: add script for translating stack dump function
Date: Mon, 19 Sep 2016 22:00:55 +0200	[thread overview]
Message-ID: <20160919200055.GA17411@lnxartpec.se.axis.com> (raw)
In-Reply-To: <CA+55aFxekTpeBPA1cwTYHOSErLStH4_H7jyh0KsuH1upRvuQ7g@mail.gmail.com>

On Mon, Sep 19, 2016 at 12:15:42PM -0700, Linus Torvalds wrote:
> Hmm. Would you mind if I change the
> 
>         addr2line -fpie $objfile $hexaddr | sed "s;$dir_prefix;;"
> 
> into
> 
>         addr2line -fpie $objfile $hexaddr |
>                 sed "s; at $dir_prefix\(\./\)*; at ;"
> 
> instead? There's two changes there: matching the " at " part (to just
> make the match stricter) but also matching any following "./" thing
> (which shows up for our include tree files, at least for me).

Note that addr2line has localized strings, so the regex with the " at "
won't match for everyone unless you invoke addr2line with LANG=C.

$ ../linux/scripts/faddr2line vmlinux free_reserved_area+61
free_reserved_area+61/0xe4:
__write_once_size på /home/rabinv/dev/linux/include/linux/compiler.h:248
(inline:ad av)set_page_count på /home/rabinv/dev/linux/include/linux/page_ref.h:76
(inline:ad av)init_page_count på /home/rabinv/dev/linux/include/linux/page_ref.h:87
(inline:ad av)__free_reserved_page på /home/rabinv/dev/linux/include/linux/mm.h:1818
(inline:ad av)free_reserved_page på /home/rabinv/dev/linux/include/linux/mm.h:1824
(inline:ad av)free_reserved_area på /home/rabinv/dev/linux/mm/page_alloc.c:6476

$ LANG=C ../linux/scripts/faddr2line vmlinux free_reserved_area+61
free_reserved_area+61/0xe4:
__write_once_size at include/linux/compiler.h:248
 (inlined by) set_page_count at include/linux/page_ref.h:76
 (inlined by) init_page_count at include/linux/page_ref.h:87
 (inlined by) __free_reserved_page at include/linux/mm.h:1818
 (inlined by) free_reserved_page at include/linux/mm.h:1824
 (inlined by) free_reserved_area at mm/page_alloc.c:6476

  parent reply	other threads:[~2016-09-19 20:01 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15  2:43 perf: perf_fuzzer lockup in perf_cgroup_attach Vince Weaver
2016-09-15  5:35 ` Stephane Eranian
2016-09-15  7:24   ` Peter Zijlstra
2016-09-15 12:10     ` Josh Poimboeuf
2016-09-16 14:48       ` [PATCH] scripts: add script for translating stack dump function offsets Josh Poimboeuf
2016-09-16 18:12         ` Linus Torvalds
2016-09-16 19:17           ` Josh Poimboeuf
2016-09-16 19:26             ` Linus Torvalds
2016-09-16 21:26               ` [PATCH v2] " Josh Poimboeuf
2016-09-17  0:09                 ` Linus Torvalds
2016-09-17  0:42                   ` Josh Poimboeuf
2016-09-17  1:59                     ` Linus Torvalds
2016-09-17  2:31                       ` Linus Torvalds
2016-09-17 18:45                       ` Josh Poimboeuf
2016-09-19 15:52                       ` [PATCH v3] scripts: add script for translating stack dump function Josh Poimboeuf
2016-09-19 18:56                         ` Linus Torvalds
2016-09-19 19:15                           ` Linus Torvalds
2016-09-19 19:28                             ` Josh Poimboeuf
2016-09-19 20:00                             ` Rabin Vincent [this message]
2016-09-19 20:24                               ` Linus Torvalds
2016-09-19 20:56                                 ` Josh Poimboeuf
2016-09-19 21:02                                   ` Linus Torvalds
2016-09-19 21:07                                     ` Josh Poimboeuf
2016-09-17  1:25                 ` [PATCH v2] scripts: add script for translating stack dump function offsets Peter Zijlstra
2016-09-17  8:15                 ` Rabin Vincent
2016-09-17 18:48                   ` Josh Poimboeuf
2016-09-17  9:11             ` [PATCH] " Vegard Nossum
2016-09-17 18:54               ` Josh Poimboeuf
2016-09-15 12:47   ` perf: perf_fuzzer lockup in perf_cgroup_attach Vince Weaver
2016-09-15  7:15 ` Peter Zijlstra
2016-09-15 12:41   ` Vince Weaver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160919200055.GA17411@lnxartpec.se.axis.com \
    --to=rabin@rab.in \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=eranian@google.com \
    --cc=jpoimboe@redhat.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=torvalds@linux-foundation.org \
    --cc=vegard.nossum@gmail.com \
    --cc=vincent.weaver@maine.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox