From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932947AbcISVfk (ORCPT ); Mon, 19 Sep 2016 17:35:40 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:36392 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752876AbcISVfh (ORCPT ); Mon, 19 Sep 2016 17:35:37 -0400 Date: Mon, 19 Sep 2016 16:35:36 -0500 From: Rob Herring To: Brendan Higgins Cc: wsa@the-dreams.de, mark.rutland@arm.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, joel@jms.id.au, jk@ozlabs.org Subject: Re: [PATCH v2 2/2] i2c: aspeed: added documentation for Aspeed I2C driver Message-ID: <20160919213536.GA19274@rob-hp-laptop> References: <201609100847.j1qUadzy%fengguang.wu@intel.com> <1473472551-11149-1-git-send-email-brendanhiggins@google.com> <1473472551-11149-2-git-send-email-brendanhiggins@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1473472551-11149-2-git-send-email-brendanhiggins@google.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 09, 2016 at 06:55:51PM -0700, Brendan Higgins wrote: > Added device tree binding documentation for Aspeed I2C controller and > busses. > > Signed-off-by: Brendan Higgins > --- > Changes for v2: > - None > --- > .../devicetree/bindings/i2c/i2c-aspeed.txt | 63 ++++++++++++++++++++++ > 1 file changed, 63 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/i2c-aspeed.txt > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt b/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt > new file mode 100644 > index 0000000..df68f2a > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt > @@ -0,0 +1,63 @@ > +Device tree configuration for the I2C controller and busses on the AST24XX > +and AST25XX SoCs. > + > +Controller: > + > + Required Properties: > + - #address-cells : should be 1 > + - #size-cells : should be 1 > + - #interrupt-cells : should be 1 > + - compatible : should be "aspeed,ast2400-i2c-controller" > + or "aspeed,ast2500-i2c-controller" > + - reg : address start and range of controller > + - ranges : defines address offset and range for busses > + - interrupts : interrupt number > + - clocks : root clock of bus, should reference the APB > + clock > + - clock-ranges : specifies that child busses can inherit clocks > + - interrupt-controller : denotes that the controller receives and fires > + new interrupts for child busses > + > +Bus: > + > + Required Properties: > + - #address-cells : should be 1 > + - #size-cells : should be 0 > + - reg : address offset and range of bus > + - compatible : should be "aspeed,ast2400-i2c-bus" > + or "aspeed,ast2500-i2c-bus" > + - bus : the bus's number Don't use indexes. The reg property is enough to id which bus is which.