From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752607AbcITGq7 (ORCPT ); Tue, 20 Sep 2016 02:46:59 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33185 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751040AbcITGq5 (ORCPT ); Tue, 20 Sep 2016 02:46:57 -0400 Date: Tue, 20 Sep 2016 08:47:02 +0200 From: Greg Kroah-Hartman To: James Simmons Cc: devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , James Simmons , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH] staging: lustre: ptlrpc: re-export lustre_swab_[lmv|lov]_mds_md Message-ID: <20160920064702.GB8527@kroah.com> References: <1474306025-1942-1-git-send-email-jsimmons@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474306025-1942-1-git-send-email-jsimmons@infradead.org> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 19, 2016 at 01:27:05PM -0400, James Simmons wrote: > Being over zealous in removing unused EXPORT_SYMBOLs two functions > lustre_swab_[lmv|lov]_mds_md exports were removed. They need to be > exported so this patch restores those EXPORT_SYMBOLS. Same mistake > was done when porting to the upstream client. How did our build testing not catch this? What needs these exports? Is it any in-kernel code? confused, greg k-h