From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754206AbcITIxF (ORCPT ); Tue, 20 Sep 2016 04:53:05 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:37395 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752364AbcITIxD (ORCPT ); Tue, 20 Sep 2016 04:53:03 -0400 Date: Tue, 20 Sep 2016 11:52:19 +0300 From: Dan Carpenter To: Greg Kroah-Hartman Cc: James Simmons , devel@driverdev.osuosl.org, James Simmons , Andreas Dilger , Linux Kernel Mailing List , Oleg Drokin , Lustre Development List Subject: Re: [PATCH] staging: lustre: ptlrpc: re-export lustre_swab_[lmv|lov]_mds_md Message-ID: <20160920085134.GH13620@mwanda> References: <1474306025-1942-1-git-send-email-jsimmons@infradead.org> <20160920064702.GB8527@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160920064702.GB8527@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 20, 2016 at 08:47:02AM +0200, Greg Kroah-Hartman wrote: > On Mon, Sep 19, 2016 at 01:27:05PM -0400, James Simmons wrote: > > Being over zealous in removing unused EXPORT_SYMBOLs two functions > > lustre_swab_[lmv|lov]_mds_md exports were removed. They need to be > > exported so this patch restores those EXPORT_SYMBOLS. Same mistake > > was done when porting to the upstream client. > > How did our build testing not catch this? What needs these exports? Is > it any in-kernel code? > > confused, It did catch it... James, every patch has to be buildable (bisectable) so the original patch is never going to be merged. regards, dan carpenter