From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932878AbcITLSL (ORCPT ); Tue, 20 Sep 2016 07:18:11 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38845 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932165AbcITLSJ (ORCPT ); Tue, 20 Sep 2016 07:18:09 -0400 Date: Tue, 20 Sep 2016 13:18:13 +0200 From: Greg Kroah-Hartman To: James Simmons Cc: devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , James Simmons , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH] staging: lustre: ptlrpc: re-export lustre_swab_[lmv|lov]_mds_md Message-ID: <20160920111813.GA17691@kroah.com> References: <1474306025-1942-1-git-send-email-jsimmons@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474306025-1942-1-git-send-email-jsimmons@infradead.org> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 19, 2016 at 01:27:05PM -0400, James Simmons wrote: > Being over zealous in removing unused EXPORT_SYMBOLs two functions > lustre_swab_[lmv|lov]_mds_md exports were removed. They need to be > exported so this patch restores those EXPORT_SYMBOLS. Same mistake > was done when porting to the upstream client. > > Signed-off-by: James Simmons > Reviewed-on: http://review.whamcloud.com/14545 > Reviewed-on: http://review.whamcloud.com/15159 > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6486 > Reviewed-by: Dmitry Eremin > Reviewed-by: Bob Glossman > Reviewed-by: John L. Hammond > Reviewed-by: Oleg Drokin > Signed-off-by: James Simmons > --- > .../staging/lustre/lustre/ptlrpc/pack_generic.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c b/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c > index 1349bf6..8717685 100644 > --- a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c > +++ b/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c > @@ -1861,6 +1861,7 @@ void lustre_swab_lmv_mds_md(union lmv_mds_md *lmm) > break; > } > } > +EXPORT_SYMBOL(lustre_swab_lmv_mds_md); I don't see anyone else using this symbol, in fact, it could now be marked static. So why export it? > void lustre_swab_lmv_user_md(struct lmv_user_md *lum) > { > @@ -1914,6 +1915,7 @@ void lustre_swab_lov_mds_md(struct lov_mds_md *lmm) > __swab16s(&lmm->lmm_stripe_count); > __swab16s(&lmm->lmm_layout_gen); > } > +EXPORT_SYMBOL(lustre_swab_lov_mds_md); This is used by other files (it's listed twice in lustre_idl.h...), so it might need to be exported, but why am I not seeing a build error without this change? confused, greg k-h