From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754149AbcITLjJ (ORCPT <rfc822;w@1wt.eu>);
        Tue, 20 Sep 2016 07:39:09 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:39244 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751635AbcITLjH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 20 Sep 2016 07:39:07 -0400
Date: Tue, 20 Sep 2016 13:39:11 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org, James Simmons <uja.ornl@yahoo.com>,
        Andreas Dilger <andreas.dilger@intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Oleg Drokin <oleg.drokin@intel.com>,
        Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH] staging: lustre: ptlrpc: re-export
 lustre_swab_[lmv|lov]_mds_md
Message-ID: <20160920113911.GA3461@kroah.com>
References: <1474306025-1942-1-git-send-email-jsimmons@infradead.org>
 <20160920064702.GB8527@kroah.com>
 <20160920085134.GH13620@mwanda>
 <20160920110500.GB16639@kroah.com>
 <20160920111612.GK13620@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160920111612.GK13620@mwanda>
User-Agent: Mutt/1.7.0 (2016-08-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 20, 2016 at 02:16:12PM +0300, Dan Carpenter wrote:
> On Tue, Sep 20, 2016 at 01:05:00PM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Sep 20, 2016 at 11:52:19AM +0300, Dan Carpenter wrote:
> > > On Tue, Sep 20, 2016 at 08:47:02AM +0200, Greg Kroah-Hartman wrote:
> > > > On Mon, Sep 19, 2016 at 01:27:05PM -0400, James Simmons wrote:
> > > > > Being over zealous in removing unused EXPORT_SYMBOLs two functions
> > > > > lustre_swab_[lmv|lov]_mds_md exports were removed. They need to be
> > > > > exported so this patch restores those EXPORT_SYMBOLS. Same mistake
> > > > > was done when porting to the upstream client.
> > > > 
> > > > How did our build testing not catch this?  What needs these exports?  Is
> > > > it any in-kernel code?
> > > > 
> > > > confused,
> > > 
> > > It did catch it...
> > 
> > It did?  Works here for me, and I didn't see an error report anywhere...
> > 
> > > James, every patch has to be buildable (bisectable) so the original
> > > patch is never going to be merged.
> > 
> > What is the "original" patch here?
> > 
> 
> [PATCH 112/124] staging: lustre: ptlrpc: remove unnecessary EXPORT_SYMBOL
> 
> kbuild responded to the email that it broke compilation on s360 but I
> don't think the breakage is arch specific?

Crap, I thought that was some other kbuild failure, my fault for
ignoring that.

Ok, I'll take half of this patch, if it gets resent...

thanks,

greg k-h