From: Greg KH <gregkh@linuxfoundation.org>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: wsa+renesas@sang-engineering.com, colin.king@canonical.com,
hofrat@osadl.org, karniksayli1995@gmail.com,
devel@driverdev.osuosl.org, xie.baoyou@zte.com.cn,
linux-kernel@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH] staging: ks7010: clean function declaration in ks_hostif.c up
Date: Tue, 20 Sep 2016 13:53:51 +0200 [thread overview]
Message-ID: <20160920115351.GA26614@kroah.com> (raw)
In-Reply-To: <1474196870-15616-1-git-send-email-baoyou.xie@linaro.org>
On Sun, Sep 18, 2016 at 07:07:50PM +0800, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/staging/ks7010/ks_wlan_net.c:3392:6: warning: no previous prototype for 'send_packet_complete' [-Wmissing-prototypes]
>
> In fact, this function is declared in
> drivers/staging/ks7010/ks_hostif.c, but should be
> declared in a header file. thus can be recognized in other file.
>
> So this patch moves the declaration into
> drivers/staging/ks7010/ks_wlan.h.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
You are sending me multiple patches for the same driver, yet no
ordering, so these don't apply for me at all. Please fix this up and
resend, I've dropped all of the ones from you for this driver now.
greg k-h
prev parent reply other threads:[~2016-09-20 11:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-18 11:07 [PATCH] staging: ks7010: clean function declaration in ks_hostif.c up Baoyou Xie
2016-09-20 11:53 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920115351.GA26614@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=hofrat@osadl.org \
--cc=karniksayli1995@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox