From: Joerg Roedel <joro@8bytes.org>
To: Baoquan He <bhe@redhat.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
kexec@lists.infradead.org, dyoung@redhat.com, xlpang@redhat.com,
Vincent.Wan@amd.com
Subject: Re: [PATCH v5 6/8] iommu/amd: Do not re-enable dev table entries in kdump
Date: Tue, 20 Sep 2016 14:42:41 +0200 [thread overview]
Message-ID: <20160920124241.GE3541@8bytes.org> (raw)
In-Reply-To: <1473951806-25511-7-git-send-email-bhe@redhat.com>
On Thu, Sep 15, 2016 at 11:03:24PM +0800, Baoquan He wrote:
> This enabling should have been done in normal kernel. It's unnecessary
> to enable it again in kdump kernel.
>
> And clean up the function comments of init_device_table_dma.
Well, no. We don't want to make any assumptions on what the previous
kernel did and what it did not. The init_device_table_dma() code should
run anyway.
next prev parent reply other threads:[~2016-09-20 12:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 15:03 [PATCH v5 0/8] Fix kdump faults on system with amd iommu Baoquan He
2016-09-15 15:03 ` [PATCH v5 1/8] iommu/amd: Detect pre enabled translation Baoquan He
2016-09-15 15:03 ` [PATCH v5 2/8] iommu/amd: add early_enable_iommu() wrapper function Baoquan He
2016-09-15 15:03 ` [PATCH v5 3/8] iommu/amd: Define bit fields for DTE particularly Baoquan He
2016-09-15 15:03 ` [PATCH v5 4/8] iommu/amd: Add function copy_dev_tables Baoquan He
2016-09-20 11:58 ` Joerg Roedel
2016-09-21 10:17 ` Baoquan He
2016-09-15 15:03 ` [PATCH v5 5/8] iommu/amd: copy old trans table from old kernel Baoquan He
2016-09-20 12:40 ` Joerg Roedel
2016-09-21 10:18 ` Baoquan He
2016-09-28 1:37 ` Baoquan He
2016-09-28 13:01 ` Baoquan He
2016-09-15 15:03 ` [PATCH v5 6/8] iommu/amd: Do not re-enable dev table entries in kdump Baoquan He
2016-09-20 12:42 ` Joerg Roedel [this message]
2016-09-21 10:20 ` Baoquan He
2016-09-15 15:03 ` [PATCH v5 7/8] iommu/amd: Don't update domain info to dte entry at iommu init stage Baoquan He
2016-09-20 12:50 ` Joerg Roedel
2016-09-21 10:26 ` Baoquan He
2016-09-21 13:21 ` Baoquan He
2016-09-15 15:03 ` [PATCH v5 8/8] iommu/amd: Update domain into to dte entry during device driver init Baoquan He
2016-09-20 12:53 ` Joerg Roedel
2016-09-21 10:31 ` Baoquan He
2016-09-27 1:51 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920124241.GE3541@8bytes.org \
--to=joro@8bytes.org \
--cc=Vincent.Wan@amd.com \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xlpang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).