From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753817AbcITMmq (ORCPT ); Tue, 20 Sep 2016 08:42:46 -0400 Received: from 8bytes.org ([81.169.241.247]:34449 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751680AbcITMmn (ORCPT ); Tue, 20 Sep 2016 08:42:43 -0400 Date: Tue, 20 Sep 2016 14:42:41 +0200 From: Joerg Roedel To: Baoquan He Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, dyoung@redhat.com, xlpang@redhat.com, Vincent.Wan@amd.com Subject: Re: [PATCH v5 6/8] iommu/amd: Do not re-enable dev table entries in kdump Message-ID: <20160920124241.GE3541@8bytes.org> References: <1473951806-25511-1-git-send-email-bhe@redhat.com> <1473951806-25511-7-git-send-email-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1473951806-25511-7-git-send-email-bhe@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 15, 2016 at 11:03:24PM +0800, Baoquan He wrote: > This enabling should have been done in normal kernel. It's unnecessary > to enable it again in kdump kernel. > > And clean up the function comments of init_device_table_dma. Well, no. We don't want to make any assumptions on what the previous kernel did and what it did not. The init_device_table_dma() code should run anyway.