From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH 6/7] perf ui/tui: Reset output width for hierarchy
Date: Tue, 20 Sep 2016 11:05:30 -0300 [thread overview]
Message-ID: <20160920140530.GA4973@kernel.org> (raw)
In-Reply-To: <CAM9d7chi5kuf=y=D57rONRwVXRXFNK-kSj5BoJWZzjHH602EMg@mail.gmail.com>
Em Tue, Sep 20, 2016 at 10:18:50AM +0900, Namhyung Kim escreveu:
> On Mon, Sep 19, 2016 at 5:05 PM, Jiri Olsa <jolsa@redhat.com> wrote:
> > On Tue, Sep 13, 2016 at 04:45:51PM +0900, Namhyung Kim wrote:
> >> + /* hierarchy entries have their own hpp list */
> >> + list_for_each_entry(node, &hists->hpp_formats, list) {
> >> + perf_hpp_list__for_each_format(&node->hpp, fmt)
> >> + perf_hpp__reset_width(fmt, hists);
> >> + }
> >
> > we could add new function hists__reset_width and use it from
> > both std and tui code
>
> Will do as a follow-up patch!
Great, I saw no problems with the patches, merged them already, should
be on their way to Ingo as soon as my test suite passes.
- Arnaldo
next prev parent reply other threads:[~2016-09-20 14:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 7:45 [PATCHSET 0/7] perf tools: Support hierarchy report with event group (v2) Namhyung Kim
2016-09-13 7:45 ` [PATCH 1/7] perf hist: Introduce hists__match_hierarchy() Namhyung Kim
2016-09-19 7:48 ` Jiri Olsa
2016-09-20 1:10 ` Namhyung Kim
2016-09-20 21:39 ` [tip:perf/core] perf hists: " tip-bot for Namhyung Kim
2016-09-13 7:45 ` [PATCH 2/7] perf hist: Introduce hists__link_hierarchy() Namhyung Kim
2016-09-19 7:59 ` Jiri Olsa
2016-09-20 1:17 ` Namhyung Kim
2016-09-20 21:39 ` [tip:perf/core] perf hists: " tip-bot for Namhyung Kim
2016-09-13 7:45 ` [PATCH 3/7] perf hist: Initialize hierachy tree explicitly Namhyung Kim
2016-09-20 21:40 ` [tip:perf/core] perf hist: Initialize hierarchy " tip-bot for Namhyung Kim
2016-09-13 7:45 ` [PATCH 4/7] perf ui/stdio: Always reset output width for hierarchy Namhyung Kim
2016-09-20 21:40 ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-09-13 7:45 ` [PATCH 5/7] perf ui/stdio: Rename print_hierarchy_header() Namhyung Kim
2016-09-20 21:41 ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-09-13 7:45 ` [PATCH 6/7] perf ui/tui: Reset output width for hierarchy Namhyung Kim
2016-09-19 8:05 ` Jiri Olsa
2016-09-20 1:18 ` Namhyung Kim
2016-09-20 14:05 ` Arnaldo Carvalho de Melo [this message]
2016-09-13 7:45 ` [PATCH 7/7] perf report: Enable group view with hierarchy Namhyung Kim
2016-09-20 21:41 ` [tip:perf/core] " tip-bot for Namhyung Kim
-- strict thread matches above, loose matches on Subject: below --
2016-09-12 6:19 [PATCHSET 0/7] perf tools: Support hierarchy report with event group (v1) Namhyung Kim
2016-09-12 6:19 ` [PATCH 6/7] perf ui/tui: Reset output width for hierarchy Namhyung Kim
2016-09-12 14:27 ` Arnaldo Carvalho de Melo
2016-09-13 1:01 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920140530.GA4973@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).