From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754064AbcITOkt (ORCPT ); Tue, 20 Sep 2016 10:40:49 -0400 Received: from mail-by2nam03on0074.outbound.protection.outlook.com ([104.47.42.74]:21728 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753442AbcITOkq (ORCPT ); Tue, 20 Sep 2016 10:40:46 -0400 X-Greylist: delayed 1080 seconds by postgrey-1.27 at vger.kernel.org; Tue, 20 Sep 2016 10:40:46 EDT Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Date: Tue, 20 Sep 2016 07:06:33 -0700 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: Nava kishore Manne CC: , , , , , , Nava kishore Manne Subject: Re: [PATCH] gpio: Added zynq specific check for special pins on bank zero Message-ID: <20160920140633.GD16583@xsjsorenbubuntu> References: <1474360324-8168-1-git-send-email-navam@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1474360324-8168-1-git-send-email-navam@xilinx.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22588.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(199003)(189002)(24454002)(377424004)(50986999)(54356999)(76176999)(8936002)(86362001)(57986006)(9786002)(81166006)(626004)(4326007)(9686002)(63266004)(1076002)(4001350100001)(2906002)(15650500001)(7846002)(586003)(2950100001)(2870700001)(50466002)(36386004)(5660300001)(33656002)(19580395003)(33716001)(19580405001)(189998001)(107886002)(47776003)(77096005)(23676002)(110136003)(85202003)(4001430100002)(76506005)(305945005)(85182001)(81156014)(87936001)(92566002)(11100500001)(6916008)(106466001)(8676002)(83506001)(6862003)(356003)(18370500001)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR02MB2883;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2NAM02FT013;1:UHdE592HgZGtijkxFbhukoJDFYUTrOuX6hTEcRRPT/tZVsb0Vu1vHCL+tAVm/Jzaz0TgUBfZMVCY62Bhyu1XhpRfHELJ3R+kAFqy6340ChKXpMrgeYvYfXuhK/BldOPX19cL/rVHG/CfpihFwAeZ/Neu4/tubY9+qCC1MtlYabXG6UWx5LThHfgLVUpmJ/ujqdxwIkeovbOSBDNmmf2wZTDPRBgXRq7Y2Rn10EcP97uPmuNc/CsAUvB06iVv2tKJk5ApSdA/RC1VFEGh90ublrP6KqjeSZ0SClEXF6WHDTi/jayeLd9wtyYDec8Y/QoVplRPOpCxfv6e6sznPkTS43MTdYFXWgP3MOWHaTFvVkitEQhl+FLBK1WUhwo93ZxLdfFcFByrccoMGB3+eGIrDtjOvtafh2/yPYto+w40pIW6RhOVrz6v9ic48Qo2R15D65S4s/c/nvTD70LgAr5uzNe4ik07zNudyQby5bj8pvofI3Hzc3WjL+eICGFtbI2krvVh7lx/9Fr/SdKe0rSL8dRruR9U8lkMQRvyLjdgBTK8jP0+kUS14tyQE687BdWO7uLUjwQXWvIVOMuRC73Go+x53WBRM5ioUezzEIwfdSmu41AMyh0yyGDQisSuZQXp X-MS-Office365-Filtering-Correlation-Id: 36af5a66-3015-4ee5-d3df-08d3e15f5627 X-Microsoft-Exchange-Diagnostics: 1;BN6PR02MB2883;2:raOE2ibiXZINCKtvqleOG4V9qqJkC35mCRr/rQiUFkVdstjWCE76fbItRGN+bKBvzHGqtbuKBXXlOWoBFUfQQhNY08xAcFYeAZMp3L1RVbYGHYduMRazsiH3xODUC0WsMbVFDoRO+FqQb8pdn5+EdBjymecR4Vl2p8ihVIBb7iWx+SnOzUzHKDmroMJp/WkU;3:ViuneqFf4ZOPiTaUXYijN06ts8ZNBqc0YtdR1qK97tzp3c7Uy28lghUxMm4AHdnSUMOcwlkEDplp5Dsc2mFsezMaiF2hdaJaQ43xEOfWj1BZKokM3iVlxOd6OKVNLjNJYF2m2fE3BU8jgl3oKRrZ5JepevzZ0kUkla/rhq1rY1p31hg2UD5/FNeAKDXSPckIWEVOL+JR13yLX8MvszWnRx0Fr3Arujtzuwtx2Ot7YC+4nWYx6CBjaaFy9nGXrkqf0SdifnbAAirLGw+5qSos5w== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:BN6PR02MB2883; X-Microsoft-Exchange-Diagnostics: 1;BN6PR02MB2883;25:2H/BUK20r9OswJ3aCzRylcB+ZD+0GyEbv33foalkPG6/eAu6HfWp9FqDPjPKg8KtiSCy9v+oB7xVXam6VUgWz8z5dyEQLkRu6fr+IszWLH9VAIGBcihRDO2mjA9AvLenqNJeEwbXjo2iRLpi1SOPYKaxGSDxNu2hDr7+g8PdEv87B9DFrdUZ6hgeZrlTwy/jyKfikLM3g8AnbTU220Czmi2wPcolu3vWVS5k/FD1l2WFTkudXAcFWgi7RVFiyodSPclxg249UyDgrHcV6/ed+1CfSlZCDsMSlB8PcaceB31J5oaD02N9wur9Yroz/r/xH/OTucoZr2ezAWLNWxzcpYGg9NvcoWOqf5XSdqFLKLPjttwcgIPXYR5RVERAnYijO1nsHmbVCf0JtUtwoHir97Z/OcpkvAlkcrNCW/RW/q3inhFeZIf/nBupBaty/+8bTsGdNn7g7VKR2k3ZiStRpU6EXZx9LZmUGskkHWwRmH2onE7/kIAJIYRvAYohAZ5KS3o1KTWz1qzq05xWSJkZPr9eeD9FJd87DlVACA5VDY2TdmcOmn2Q6XFH/R0OiwIwGObt7APo6xKL/wrVqg8894SkuEg1R9PM/VTlgCz9vmEufgpP+CSU+egpYNBrXa29OlLVfIZIT2Wawgv7uX/t5eqNWc0C7oJG7jAZt6+QiAhQxLvnezhv1OTeAx2YlcvsoiflKKIK6qYmsGGs+pxxAWRbIThdR8aHR5YkGSIUpt9KBZqIhrD1BjZormyYGnjf+NJZuuRuhgRyAMLwQibdKBqSPt0pUL74d/jdBq3S1BY3v/YFqSLA3GSnphuZTtM74mMS6mDIOUZvGO0wbjq+UA== X-Microsoft-Exchange-Diagnostics: 1;BN6PR02MB2883;31:l2SQkCgt/hxp05yHzeiiU4dJiJ8nM5bExNPDXoHdDJ/Y2oF9s2yKWSdzup/+7iaBU1sbdLxcKOxrGG0ZrYFSF9zVhJUF2feQX8AD3wra2c3s6xEbq3Pl54nHPFCxHIIx0VRD/n9MUCJ+taSXNijms31ivF4G14b1ZlzF6VTzY/qKglNsKl8OClmO6TgaH93RLjgfAEzy9nUo+Y54YuKw0JW98e/H/Fem2qKf6d2bz/4=;20:OqrcENpBf0GtKygn5vBxi3+Vof+8KDi5bUfC2ymhDhlrhj5ILE8F7ZWg6Uhs6VJyFY5Fh828mo8+MNMH0NoN0QLz4nlL0f+5V2Bm/t6TcMrZnDEziOhCgkyu9OM3NmUyFgtofYvZJNM9iFAKleGfzoplnM5ZNDWPF4TRSthGXoj32Y4YNfe6xXZkQJNANeZ/NNVrrJQe0hIR/IzNhald3ExXKMv+It8Af7rBurMa4DbxI5s7FnLyIutKL6d6fXNPnGMr/9+y16JGhyJxWpeOP1CyDeOrp26piuN+GHJZ1a/TUFvm7Kyg/9CCt2Qq2zI4li92WG5b/9VZjk6uPABH3aSmypI16MEAf4BXg0WfAUPw6RYIdagAkJ5s/f8oJhhj4Z6+hLMw2y7IvkVncDpiiLbB9wIV1PuOx2wXARQPVESkjlqLNLdrBrH0/vuWF+DZPIYIqpLOxAjEEXigSu91QU365owaU7p/iPQZwbQWLgBBvNkX/1pQbcObMJHlDH9o X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(13015025)(13023025)(13017025)(13024025)(13018025)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:BN6PR02MB2883;BCL:0;PCL:0;RULEID:;SRVR:BN6PR02MB2883; X-Microsoft-Exchange-Diagnostics: 1;BN6PR02MB2883;4:n/T/UB+BIGpNZCt6Hk8EUSDhBCM7iGZU/ahBuH91qFycXWEjYdu+tvTixqGthLmXv9HVZbkkgvQnvBbQfkpawoGIkAAgWmK16Wz1gLFKUMLSWl/5ffVYLOe0NwZQ33bxF1QZbE0TUEk//Ic5J2ZhwBr7mmrcI2a1OhGn7DvKwSOXoIFi0WkWRUUt0J92ZcoZng7ySkfmZjNoegUUThz8+7u6eI52IjQCqBwe7cDdwUov4GD9nrTvp5zJqSyhbUH0uhIeav8kx0IVdDoIgmJ+bAeCnEAd8kx7fmH5VkZjj0Khz9M94pKOQDttXHhyoiuaW7NKdPGQ8Uv30cEsItHLqym6EPmAEZ1UV9dqx1aDQjYNNivl4BfKLRBi6gqF59eg/RI55T7hgdEAxE9V567X7Y0bZDFWnpu+9GAoU5rtRRCjrGCXrLy/mUTIoIfFjB5Dk4b3W3BBF2jIYI8ChSYDLlcWl7033Fxn9WyvwG9XSlpin8sVrf1dyQW2IpId/Hvl7tt5LsXC55Jt5u41SxiZX0189GoLIcBRT4Q7vmaOctc= X-Forefront-PRVS: 0071BFA85B X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjAyTUIyODgzOzIzOmJubzcwTVM3RmNPUGpodEhQVU9CS3FFd1E2?= =?utf-8?B?SmRmSm90eFpQamxpbk9RZHZkT0dsZ0tWYlRJenJOM0RxdVMvK1RlOUhjalM2?= =?utf-8?B?MUJlL3d3RnRTUnFMUjBWT252d2N0NUwzUlQ5T3hVL0tRREtscTRCamgwWDVa?= =?utf-8?B?NzBGMmlMWVpvSGV3WVpBV0NxWi93NTRLZGZ0SXZ6blRUVHZxUWRSUmVzN0w4?= =?utf-8?B?cmVFSFhNZVgvbXZvNURMeDU2eUY3YVdxNDVwY2x2dEszVHR3ZFJYN1FPZjBr?= =?utf-8?B?bjcvRGRCZTNHWnE4L0lHcDVQRHpQd2tXelJmM1NKYVRQSUthV1ZoM1NnN1RH?= =?utf-8?B?dFgzRnpyRHdtQzZHVGZWQ1paVWozRFVIdUhSTHZqSHU4Q3hRQ2J3bG9acGJX?= =?utf-8?B?WE9nYzFoYnJsaDFXSExaVGlyckovMW4xUUpTQkxMY1VJR0J3dGhLcndLVDdo?= =?utf-8?B?TitsWGhqaTA2djBHSGIvc1ZNNHgzQmFtZkhqelVualVGRWpYYjlqQTVKd3NS?= =?utf-8?B?YmVWaGdzKzRMendKTnRtS2RQa1FhdzliQVd2d0xSQjhCR0JReEowVE9VckZv?= =?utf-8?B?cEg2WExoVkhLbXpBWEowRGpTb0drVGptWUFuYk4xZ3ZnZVJDbDY5S2x6cTRO?= =?utf-8?B?Z0RSeERERTV3SXJ2cEhiOG5sYVJsZFlWYmIxWWwveVQ1OFFOL3luVkpqYktE?= =?utf-8?B?U1RVUUNuWit6WWRkL1hHakJYczlZMVlpMGd2OXhVdytWYVYzOTdoSUx1UG9W?= =?utf-8?B?Nmg4M1U3dktNc0VoVDRYZjEwTEsxZFhmME5MNmZtNFdQdmJlMW9sQ2thYWZo?= =?utf-8?B?ejZzbFBTbFBDcmQ3SnZsT216K3E5RWlRMFAzNlZoQ1ppOUtuU2tlNXgrVU9H?= =?utf-8?B?QWhnOGlnMWVqYldDUGtmRkFsRk5oVlppQXhvd2VBalZiM3dRMGxMUmFhUzJH?= =?utf-8?B?Z2k5UTVXcnhRbjMyMDNKV2h0cXZqZUlicWVNQjV1bThnQ1lqR2xQZE15WUpK?= =?utf-8?B?aFJ6MmwrTzB6NjBkUTdDcUNueUIvdXVuaGQ5N1ExL2JVY0tlL3AvK0lHUG1K?= =?utf-8?B?OVhFdzdzdEs4cC9IYUlEYmRmQVZ1Y0Rqd1NtbHkrQkRMYUMwTkttTytEU0hj?= =?utf-8?B?amw4enpMWkJQQnVoNFJQNmtQNU5VNmY2eWhCNTlVaERUMlE3QTljdklpZTRk?= =?utf-8?B?ZS9CSTdvaGdzWVMvQ2tNenQyeHJRbXlNUHpKaFl4QkJvZ1V4R3NSZ2hpdUts?= =?utf-8?B?NkVzSk9YSnRJT3J0b3pZUzNEVVI3MWF1WEtPWlFMb2h4MDBYVGsrdmFsSC90?= =?utf-8?B?VFdjM3dHZ2ZodWRhZ1hVamxIL1ppQUdDV2FsZWJFdk1SSFZwcjRkVGN0dEo5?= =?utf-8?B?c2QrNG95ZXhqYWFuV1dobzRpWXpsc0c3S3d0R01KRitaZjBzcmVUeFRQVGNH?= =?utf-8?B?ZUgrRzkxOGZWUlVZWVJSTWVkcnh6T0hOSzdvTHI5WmF5TEJqd3BhRis3dng5?= =?utf-8?B?VVo4TkRId3U0ZjdoSmFFWSs1SnRFVVFDMis5Njd1YWthNjNyMXA1UnJmUkNn?= =?utf-8?B?UjArYVlmY280djFzdWgxdWdJMUdmRXJ4bjhkRWNJMTlMbWJqcjdKSC9mZlNS?= =?utf-8?B?Mk9xcVU4TWVra25vbHBEbDAvZlE4c0tZaGgvQmtrVVBIdGNxK09oQks1SlRR?= =?utf-8?B?NXc0RVkxV2pXTTVxaTJDTXFucDEzTldIRU1mYkxxWmZuTnVkanFDMXFXcjYx?= =?utf-8?B?TTk3T3VsRnBadFdtN05kZjN5dEdkS3lMdHBxZXU0UFNWU2cvNENlWm9MUUtF?= =?utf-8?B?YkVLWjZiMzdJUHQ3WU9YckJpKzdlNmxEbjNxR0o1TGtyUnBHSzZKaG1QOUtG?= =?utf-8?B?aW5LeFE3VEVoNHdwZi9KVHlMTUQ5ZFIyMVdFM3FDd0hQOUErUWVDVnRFaFJO?= =?utf-8?B?UTBUeVhaK01RPT0=?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR02MB2883;6:wMHOXfP3CYLm5P8laDjpyOFWJ6uz8jh4akr1ShmLBhUzPqHQtnHCxBgOLYlol3LO2UcvFVIcSYpP4ZLuwz+5IKLU40li0LJte5FYzLtRAkmmnOMvKH/W08LNWvP3+uQZ0Wu9tV+/+n512MI9IsVRFWkbVY8lWONAk5+/H02E2BKXiZlHoRxMMKJG0E/buo8EPoEg10wjVqxcLRGaWX0QZ3hZhJAGtwFKxNIuTHsDYy382lxv34dIP4sizI453X+tmKfIIc9qGZBhZjYDHrPLKeDx6IoSlTaHpoBX/TA5As5YKU7MLaNyjMc5DwMlTylZDEmcCpwQhqJmD6zPHQS8Yg==;5:BJ1p6SHmaaCq/hyzwUD7kYPoKDElFMKbJNxzobsjQSPFSzQ2BBg0JX7Q6WApl/gT0c158dm4jb3QKLNTWpwKS0DS2jcDrogqk3qLumtK9Rf9QTz6zc/xPXKT2PasGkqbJdf1L31NKZK+9hMoq6srKw==;24:mFjH/GPLxUqOXMF2ndT09BD8dQrbfVqY5GMwAGNkzrHAqPhpF7POtqWkoeSE4x4KTj/KfGIuEq2Z77t4Tt+K9XZMdCzNsGhXUENOHHxJGKI=;7:1dQDCjptH6VAglfJ8kquAaxJuRbwdFHTucS8hgBMC3fmDOozuJVgcIyOikcCfq78ZQA6UcnSRADm9cqSByWoD1t0YxB162grNTHj1Eli09GIgvuqiF2V1oLpT14/SM9FDDwbg3m0kQzR8i983FaqOfex9pSKLHX7VWjrgWHukhqv4IghLxLbW2lSZX51TKMMqgZl0oarlvAAIs2Tp8uvT8ZOi5Dnzyfmw2fSVPbQEAT72HNjP4ATJDqQEVe2uAqbj7QsCrUIegeEhqpSWMf/4DecG7e66migtiiUizVlBYmsT40PTBbECvCMGSiBSHkc SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2016 14:06:37.1090 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB2883 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-09-20 at 14:02:04 +0530, Nava kishore Manne wrote: > From: Nava kishore Manne > > This patch adds zynq specific check for bank 0 pins 7 and 8 > are special and cannot be used as inputs > > Signed-off-by: Nava kishore Manne > --- > drivers/gpio/gpio-zynq.c | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c > index e72794e..eae9d24 100644 > --- a/drivers/gpio/gpio-zynq.c > +++ b/drivers/gpio/gpio-zynq.c > @@ -96,6 +96,10 @@ > /* GPIO upper 16 bit mask */ > #define ZYNQ_GPIO_UPPER_MASK 0xFFFF0000 > > +/* For GPIO quirks */ > +#define ZYNQ_GPIO BIT(0) > +#define ZYNQMP_GPIO BIT(1) I'd make sure all quirks are easily identifiable and call them something like 'ZYNQ_GPIO_QUIRK_FOO' Apart from that: Acked-by: Sören Brinkmann Sören