From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933262AbcITRGF (ORCPT ); Tue, 20 Sep 2016 13:06:05 -0400 Received: from mail.kernel.org ([198.145.29.136]:56042 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932487AbcITRGC (ORCPT ); Tue, 20 Sep 2016 13:06:02 -0400 Date: Tue, 20 Sep 2016 20:05:53 +0300 From: Leon Romanovsky To: Salil Mehta Cc: "dledford@redhat.com" , "Huwei (Xavier)" , oulijun , "Zhuangyuzeng (Yisen)" , "xuwei (O)" , "mehta.salil.lnk@gmail.com" , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linuxarm Subject: Re: [PATCH for-next 18/20] IB/hns: Update the rq head when modify qp state Message-ID: <20160920170553.GU26673@leon.nu> References: <1473417051-99560-1-git-send-email-salil.mehta@huawei.com> <1473417051-99560-19-git-send-email-salil.mehta@huawei.com> <20160915101246.GX26069@leon.nu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Wlbg71WMOPzcvmIn" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Wlbg71WMOPzcvmIn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 20, 2016 at 04:56:35PM +0000, Salil Mehta wrote: > > > > -----Original Message----- > > From: Leon Romanovsky [mailto:leon@kernel.org] > > Sent: Thursday, September 15, 2016 11:13 AM > > To: Salil Mehta > > Cc: dledford@redhat.com; Huwei (Xavier); oulijun; Zhuangyuzeng (Yisen); > > xuwei (O); mehta.salil.lnk@gmail.com; linux-rdma@vger.kernel.org; > > linux-kernel@vger.kernel.org; Linuxarm > > Subject: Re: [PATCH for-next 18/20] IB/hns: Update the rq head when > > modify qp state > > > > On Fri, Sep 09, 2016 at 06:30:49PM +0800, Salil Mehta wrote: > > > From: Lijun Ou > > > > > > The rq head in qpc was zero will miss the rq wqes which > > > have be sent, so here we should take the real value. > > > > > > Signed-off-by: Lijun Ou > > > Reviewed-by: Wei Hu (Xavier) > > > Signed-off-by: Salil Mehta > > > --- > > > drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c > > b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c > > > index bdd9453..7a61d7e 100644 > > > --- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c > > > +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c > > > @@ -2266,7 +2266,8 @@ static int hns_roce_v1_m_qp(struct ib_qp *ibqp, > > const struct ib_qp_attr *attr, > > > > > > roce_set_field(context->qpc_bytes_68, > > > QP_CONTEXT_QPC_BYTES_68_RQ_HEAD_M, > > > - QP_CONTEXT_QPC_BYTES_68_RQ_HEAD_S, 0); > > > + QP_CONTEXT_QPC_BYTES_68_RQ_HEAD_S, > > > + hr_qp->rq.head); > > > > Are you sure that it should be list_head and not value? > This is correct. Variable head is not list_head but a u32 value. > Hope I understood your point correctly. Thanks, you understood me right. The name "head" mislead me. Sorry for that. > > Best regards > Salil > > > > > roce_set_field(context->qpc_bytes_68, > > > QP_CONTEXT_QPC_BYTES_68_RQ_CUR_INDEX_M, > > > QP_CONTEXT_QPC_BYTES_68_RQ_CUR_INDEX_S, 0); > > > -- > > > 1.7.9.5 > > > > > > -- > > > To unsubscribe from this list: send the line "unsubscribe linux-rdma" > > in > > > the body of a message to majordomo@vger.kernel.org > > > More majordomo info at http://vger.kernel.org/majordomo-info.html --Wlbg71WMOPzcvmIn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJX4WxxAAoJEORje4g2clinoB4QAJk4S001neJPozuoiCmcJtHq K/JvtX9q+q0wgZbJi8IJXEC+NdOHW+UrShLMeRVTPcX5eLl4Xcg/8L2AQ8nIvpgP 9BslT2A8WbyFrUd2Db3r7rcSI+9cr7OGQflEovatwGt09nYca+YzyUI9K2A8F0mm iLWTVzGc43hb87JWGdzzfZS4dXF/2UFZtALGwTzB4G4skQPex9b1Yw2gMkG8/wsI efDRZhlshN7xRVnNw0tilCBZsnb6vqoXtxjbJjhngDotl7kJIUMFIuFSNGENSc1C bZp96NyN+qf1MbaLmoqbQLOAcrC/zYjFW/8k0hgS7/ig+WdDUfsC1Cz2OFjoJRBa Kn0+wqnOujyH8Pw2vvtT2yMi2hHP3IWIyfbaEdZfXGZXrQPX/BRfJfWN7dxt6R+x qm9U39QKla2vfi3eBbw9dP9AvbIF2kQJ3pQRneH0bsJrfo+9CUOJowdbvacNmMkJ Huo2m8UgDbM72ePu/5MfCKeS0O55FZJSgvbr7E3K2kZ9RhYd3H2yZ7Kf/7IrMETz Wg+giP0OgtMPqePQEPDHK4cgwCbJaJHkWv0+zoQYABaCaoGz+cb2rlVU38uQoqCp asGf9zpbZk4byg7h0DdgzYpjzpaoV7UFwoKUCe6VQxs8ObxMj3OvAT9EHNTVaApu ieAkxLTuX+HQNNPR7bJv =GDFn -----END PGP SIGNATURE----- --Wlbg71WMOPzcvmIn--