From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in ATU
Date: Wed, 21 Sep 2016 01:42:27 +0200 [thread overview]
Message-ID: <20160920234227.GA1730@lunn.ch> (raw)
In-Reply-To: <87wpi7idkr.fsf@ketchup.i-did-not-set--mail-host-address--so-tickle-me>
On Mon, Sep 19, 2016 at 09:07:16PM -0400, Vivien Didelot wrote:
> Hi Andrew,
>
> Andrew Lunn <andrew@lunn.ch> writes:
>
> > On Mon, Sep 19, 2016 at 07:56:11PM -0400, Vivien Didelot wrote:
> >> An address can be loaded in the ATU with multiple ports, for instance
> >> when adding multiple ports to a Multicast group with "bridge mdb".
> >>
> >> The current code doesn't allow that. Add an helper to get a single entry
> >> from the ATU, then set or clear the requested port, before loading the
> >> entry back in the ATU.
> >>
> >> Note that the required _mv88e6xxx_atu_getnext function is defined below
> >> mv88e6xxx_port_db_load_purge, so forward-declare it for the moment. The
> >> ATU code will be isolated in future patches.
> >>
> >> Fixes: 83dabd1fa84c ("net: dsa: mv88e6xxx: make switchdev DB ops generic")
> >
> > Is this a real fixes? You don't make it clear what goes wrong. I
> > assume adding the same MAC address for a second time but for a
> > different port removes the first entry for the old port?
>
> Yes, this is what happens, sorry for the bad message. Below is an
> example with the relevant hardware bits.
>
> Here's the current behavior, without this patch:
>
> # bridge mdb add dev br0 port lan0 grp 238.39.20.86
>
> FID MAC Addr State Trunk? DPV/Trunk ID
> 0 01:00:5e:27:14:56 MC_STATIC n 0 - - - - - -
>
> # bridge mdb add dev br0 port lan2 grp 238.39.20.86
>
> FID MAC Addr State Trunk? DPV/Trunk ID
> 0 01:00:5e:27:14:56 MC_STATIC n - - 2 - - - -
>
> Here's the new behavior, with this patch:
>
> # bridge mdb add dev br0 port lan0 grp 238.39.20.86
>
> FID MAC Addr State Trunk? DPV/Trunk ID
> 0 01:00:5e:27:14:56 MC_STATIC n 0 - - - - - -
>
> # bridge mdb add dev br0 port lan2 grp 238.39.20.86
>
> FID MAC Addr State Trunk? DPV/Trunk ID
> 0 01:00:5e:27:14:56 MC_STATIC n 0 - 2 - - - -
Hi Vivien
it would be nice to update the commit message with this text.
Otherwise
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2016-09-20 23:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 23:56 [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in ATU Vivien Didelot
2016-09-20 0:19 ` Andrew Lunn
2016-09-20 0:29 ` Vivien Didelot
2016-09-20 0:32 ` Andrew Lunn
2016-09-20 0:41 ` Andrew Lunn
2016-09-20 1:07 ` Vivien Didelot
2016-09-20 23:42 ` Andrew Lunn [this message]
2016-09-21 4:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920234227.GA1730@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).