From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754699AbcIUACU (ORCPT ); Tue, 20 Sep 2016 20:02:20 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:50517 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753964AbcIUACN (ORCPT ); Tue, 20 Sep 2016 20:02:13 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 495176141A Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Tue, 20 Sep 2016 17:02:11 -0700 From: Stephen Boyd To: Alexandre Belloni Cc: Nicolas Ferre , Boris Brezillon , Michael Turquette , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v3 1/5] clk: at91: move slow clock controller clocks to sckc.c Message-ID: <20160921000211.GH8319@codeaurora.org> References: <20160920205833.19638-1-alexandre.belloni@free-electrons.com> <20160920205833.19638-2-alexandre.belloni@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160920205833.19638-2-alexandre.belloni@free-electrons.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/20, Alexandre Belloni wrote: > Move all clocks related to the slow clock controller to sckc.c. This avoids > extern definitions and allows to remove sckc.h > > Signed-off-by: Alexandre Belloni > --- Applied to clk-next drivers/clk/at91/sckc.c:146:13: warning: symbol 'of_at91sam9x5_clk_slow_osc_setup' was not declared. Should it be static? drivers/clk/at91/sckc.c:260:13: warning: symbol 'of_at91sam9x5_clk_slow_rc_osc_setup' was not declared. Should it be static? drivers/clk/at91/sckc.c:359:13: warning: symbol 'of_at91sam9x5_clk_slow_setup' was not declared. Should it be static? ----8<---- diff --git a/drivers/clk/at91/sckc.c b/drivers/clk/at91/sckc.c index f6ed711af738..311956abf4aa 100644 --- a/drivers/clk/at91/sckc.c +++ b/drivers/clk/at91/sckc.c @@ -143,8 +143,8 @@ at91_clk_register_slow_osc(void __iomem *sckcr, return hw; } -void __init of_at91sam9x5_clk_slow_osc_setup(struct device_node *np, - void __iomem *sckcr) +static void __init +of_at91sam9x5_clk_slow_osc_setup(struct device_node *np, void __iomem *sckcr) { struct clk_hw *hw; const char *parent_name; @@ -257,8 +257,8 @@ at91_clk_register_slow_rc_osc(void __iomem *sckcr, return hw; } -void __init of_at91sam9x5_clk_slow_rc_osc_setup(struct device_node *np, - void __iomem *sckcr) +static void __init +of_at91sam9x5_clk_slow_rc_osc_setup(struct device_node *np, void __iomem *sckcr) { struct clk_hw *hw; u32 frequency = 0; @@ -356,8 +356,8 @@ at91_clk_register_sam9x5_slow(void __iomem *sckcr, return hw; } -void __init of_at91sam9x5_clk_slow_setup(struct device_node *np, - void __iomem *sckcr) +static void __init +of_at91sam9x5_clk_slow_setup(struct device_node *np, void __iomem *sckcr) { struct clk_hw *hw; const char *parent_names[2]; -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project