From: Michal Hocko <mhocko@kernel.org>
To: Chen Gang <chengang@emindsoft.com.cn>
Cc: akpm@linux-foundation.org, minchan@kernel.org, vbabka@suse.cz,
mgorman@techsingularity.net, gi-oh.kim@profitbricks.com,
opensource.ganesh@gmail.com, hughd@google.com,
kirill.shutemov@linux.intel.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Chen Gang <gang.chen.5i5j@gmail.com>
Subject: Re: [PATCH] mm: migrate: Return false instead of -EAGAIN for dummy functions
Date: Wed, 21 Sep 2016 10:11:50 +0200 [thread overview]
Message-ID: <20160921081149.GE10300@dhcp22.suse.cz> (raw)
In-Reply-To: <57E1B2F4.5070009@emindsoft.com.cn>
On Wed 21-09-16 06:06:44, Chen Gang wrote:
> On 9/20/16 16:09, Michal Hocko wrote:
[...]
skipping the large part of the email because I do not have a spare time
to discuss this.
> > So what is the point of this whole exercise? Do not take me wrong, this
> > area could see some improvements but I believe that doing int->bool
> > change is not just the right thing to do and worth spending both your
> > and reviewers time.
> >
>
> I am not quite sure about that.
Maybe you should listen to the feedback your are getting. I do not think
I am not the first one here.
Look, MM surely needs some man power. There are issues to be solved,
patches to review. Doing the cleanups is really nice but there are more
serious problems to solve first. If you want to help then starting
with review would be much much more helpful and hugely appreciated. We
are really lacking people there a _lot_. Just generating more work for
reviewers with something that doesn't make any real difference in the
runtime is far less helpful IMHO.
Thanks.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2016-09-21 8:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-17 7:20 [PATCH] mm: migrate: Return false instead of -EAGAIN for dummy functions chengang
2016-09-17 15:46 ` Michal Hocko
2016-09-19 21:46 ` Chen Gang
2016-09-20 8:09 ` Michal Hocko
2016-09-20 22:06 ` Chen Gang
2016-09-21 8:11 ` Michal Hocko [this message]
2016-09-21 8:13 ` Vlastimil Babka
2016-09-25 13:59 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160921081149.GE10300@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=chengang@emindsoft.com.cn \
--cc=gang.chen.5i5j@gmail.com \
--cc=gi-oh.kim@profitbricks.com \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=minchan@kernel.org \
--cc=opensource.ganesh@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox