From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756609AbcIUKUz (ORCPT ); Wed, 21 Sep 2016 06:20:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35172 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756569AbcIUKUx (ORCPT ); Wed, 21 Sep 2016 06:20:53 -0400 Date: Wed, 21 Sep 2016 18:20:44 +0800 From: Baoquan He To: Joerg Roedel Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, dyoung@redhat.com, xlpang@redhat.com, Vincent.Wan@amd.com Subject: Re: [PATCH v5 6/8] iommu/amd: Do not re-enable dev table entries in kdump Message-ID: <20160921102044.GC13350@x1.redhat.com> References: <1473951806-25511-1-git-send-email-bhe@redhat.com> <1473951806-25511-7-git-send-email-bhe@redhat.com> <20160920124241.GE3541@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160920124241.GE3541@8bytes.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 21 Sep 2016 10:20:47 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/20/16 at 02:42pm, Joerg Roedel wrote: > On Thu, Sep 15, 2016 at 11:03:24PM +0800, Baoquan He wrote: > > This enabling should have been done in normal kernel. It's unnecessary > > to enable it again in kdump kernel. > > > > And clean up the function comments of init_device_table_dma. > > Well, no. We don't want to make any assumptions on what the previous > kernel did and what it did not. The init_device_table_dma() code should > run anyway. Yes, right. I forget people could set amd_iommu=off in 1st kernel, but remove it in kdump kernel. Will change and merge the comment clean up into another patch. >